[webkit-changes] [WebKit/WebKit] 1be8c3: Remove unneeded code in HistoryController::createI...

[Charlie Wolfe]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 1be8c36a062cebef0d61c90905531f40297318ab
      https://github.com/WebKit/WebKit/commit/1be8c36a062cebef0d61c90905531f40297318ab
  Author: Charlie Wolfe <charliew at apple.com>
  Date:   2024-05-06 (Mon, 06 May 2024)

  Changed paths:
    M Source/WebCore/loader/HistoryController.cpp

  Log Message:
  -----------
  Remove unneeded code in HistoryController::createItemTree
https://bugs.webkit.org/show_bug.cgi?id=273790
rdar://127621115

Reviewed by Pascoe.

This code was added 16 years ago in 24907 at main. It was intended to fix an issue where reloading would
create a history item for an <object> element that might not have loaded. Today, history items are not
created upon reloading. With site isolation, we are not always able to check if a child frame has loaded,
so we should just remove this code.

The test that was added in 24907 at main still passes:
http/tests/navigation/fallback-anchor-reload.html

* Source/WebCore/loader/HistoryController.cpp:
(WebCore::HistoryController::createItemTree):

Canonical link: https://commits.webkit.org/278433@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications