[webkit-changes] [WebKit/WebKit] c3c0e1: TestWebKitAPI.SelectionTests.SelectedTextAfterSele...

[Wenson Hsieh]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: c3c0e1ac6fcd3cba58290cc52688b4ac0dedc098
      https://github.com/WebKit/WebKit/commit/c3c0e1ac6fcd3cba58290cc52688b4ac0dedc098
  Author: Wenson Hsieh <wenson_hsieh at apple.com>
  Date:   2024-05-06 (Mon, 06 May 2024)

  Changed paths:
    M Tools/TestWebKitAPI/Tests/ios/SelectionByWord.mm

  Log Message:
  -----------
  TestWebKitAPI.SelectionTests.SelectedTextAfterSelectingWordForReplacement times out on iPhone Simulator
https://bugs.webkit.org/show_bug.cgi?id=273736
rdar://127547635

Reviewed by Abrar Rahman Protyasha.

Augment the `SelectionChangeListener` helper class to be compatible with the case where WebKit uses
BrowserEngineKit's `BETextInput`. Instead of calling directly into `-selection(Will|Did)Change:`,
we now call into `-[BETextInputDelegate selection(Will|Did)ChangeForTextInput:]`.

* Tools/TestWebKitAPI/Tests/ios/SelectionByWord.mm:
(-[SelectionChangeListener selectionWillChangeForTextInput:]):
(-[SelectionChangeListener selectionDidChangeForTextInput:]):
(-[SelectionChangeListener shouldDeferEventHandlingToSystemForTextInput:context:]):
(-[SelectionChangeListener textInput:setCandidateSuggestions:]):
(-[SelectionChangeListener textInput:deferReplaceTextActionToSystem:]):
(-[SelectionChangeListener invalidateTextEntryContextForTextInput:]):
(TEST(SelectionTests, SelectedTextAfterSelectingWordForReplacement)):

Canonical link: https://commits.webkit.org/278428@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications