[webkit-changes] [WebKit/WebKit] 35339e: [webkitpy] Remove build version requirement for si...

[Ben]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 35339e704b5d6701b244ee5cd7f71adbe8b3b2cd
      https://github.com/WebKit/WebKit/commit/35339e704b5d6701b244ee5cd7f71adbe8b3b2cd
  Author: Ben Schwartz <ben_schwartz at apple.com>
  Date:   2024-05-06 (Mon, 06 May 2024)

  Changed paths:
    M Tools/Scripts/webkitpy/xcode/simulated_device.py

  Log Message:
  -----------
  [webkitpy] Remove build version requirement for simulated device match.
https://bugs.webkit.org/show_bug.cgi?id=273515
rdar://127187171

Reviewed by Sam Sneddon.

My recent changes in 277884 at main fixed a bug where the wrong type of device was being
booted when running tests in OS simulators. As part of those changes, I added a check
to verify that the build versions matched the request. This caused run-webkit-tests to
not use mounted runtimes, even if the simulator was already booted.

This PR removes the heuristics that check if the device is using the same build version
as default, and instead only checks for device type matching the request.

* Tools/Scripts/webkitpy/xcode/simulated_device.py:
(SimulatedDeviceManager._create_or_find_device_for_request): Remove build_version check.

Canonical link: https://commits.webkit.org/278414@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications