[webkit-changes] [WebKit/WebKit] 0a9423: [WebGPU] GPUBuffer should not destroy the underlyi...

[mwyrzykowski]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 0a9423a613b0c0c3fd2eb10cafee1b8c03d2148b
      https://github.com/WebKit/WebKit/commit/0a9423a613b0c0c3fd2eb10cafee1b8c03d2148b
  Author: Mike Wyrzykowski <mwyrzykowski at apple.com>
  Date:   2024-05-06 (Mon, 06 May 2024)

  Changed paths:
    M Source/WebCore/Modules/WebGPU/GPUBuffer.cpp
    M Source/WebGPU/WebGPU/Pipeline.mm

  Log Message:
  -----------
  [WebGPU] GPUBuffer should not destroy the underlying buffer from its destructor
https://bugs.webkit.org/show_bug.cgi?id=273606
<radar://127408015>

Reviewed by Dan Glastonbury.

The first and last line of the dtor were useless but the destroy
call should have not existed, since the buffer may still be used in the GPU
process after it is GC'ed from the JS layer.

Observed in a flaky fashion from https://webgpu.github.io/webgpu-samples/?sample=deferredRendering
where some command buffers were failing, occassionally.

* Source/WebCore/Modules/WebGPU/GPUBuffer.cpp:
(WebCore::GPUBuffer::~GPUBuffer): Deleted.

Canonical link: https://commits.webkit.org/278412@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications