[webkit-changes] [WebKit/WebKit] 202bb7: [webkitscmpy] Read and write BitBucket comments

[Jonathan Bedard]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 202bb7baa3ad3688b5fb23f74782cd7ee52ced18
      https://github.com/WebKit/WebKit/commit/202bb7baa3ad3688b5fb23f74782cd7ee52ced18
  Author: Jonathan Bedard <jbedard at apple.com>
  Date:   2024-05-06 (Mon, 06 May 2024)

  Changed paths:
    M Tools/Scripts/libraries/webkitscmpy/webkitscmpy/mocks/remote/bitbucket.py
    M Tools/Scripts/libraries/webkitscmpy/webkitscmpy/remote/bitbucket.py
    M Tools/Scripts/libraries/webkitscmpy/webkitscmpy/test/pull_request_unittest.py

  Log Message:
  -----------
  [webkitscmpy] Read and write BitBucket comments
https://bugs.webkit.org/show_bug.cgi?id=273007
rdar://126769869

Reviewed by Elliott Williams.

Provide Python functions to both write and read in-line PR comments.

* Tools/Scripts/libraries/webkitscmpy/webkitscmpy/mocks/remote/bitbucket.py:
(BitBucket.request): Mock endpoints to write and read PR comments.
* Tools/Scripts/libraries/webkitscmpy/webkitscmpy/remote/bitbucket.py:
(BitBucket.PRGenerator.comment): Allow comments to define an anchor.
(BitBucket.PRGenerator.comments): Skip actions which have 'commentAnchor'.
(BitBucket.PRGenerator._position_converters): Provide dictionaries to convert from
relative to absolute diff positions and visa versa.
(BitBucket.PRGenerator._diff_comments): Return a list of comments anchored to a relative
diff position.
(BitBucket.PRGenerator.review): Add 'diff_comments' argument.
(BitBucket.PRGenerator.diff): Added.
* Tools/Scripts/libraries/webkitscmpy/webkitscmpy/test/pull_request_unittest.py:

Canonical link: https://commits.webkit.org/278406@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications