[webkit-changes] [WebKit/WebKit] cf23d2: [WebGPU] UAF in GPUBuffer::getMappedRange

[mwyrzykowski]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: cf23d24d68de75c5442ae4d356af363131335bd9
      https://github.com/WebKit/WebKit/commit/cf23d24d68de75c5442ae4d356af363131335bd9
  Author: Mike Wyrzykowski <mwyrzykowski at apple.com>
  Date:   2024-05-05 (Sun, 05 May 2024)

  Changed paths:
    M LayoutTests/platform/mac-wk2/TestExpectations
    M Source/WebCore/Modules/WebGPU/GPUBuffer.cpp
    M Source/WebCore/Modules/WebGPU/Implementation/WebGPUBufferImpl.cpp
    M Source/WebCore/Modules/WebGPU/Implementation/WebGPUBufferImpl.h
    M Source/WebCore/Modules/WebGPU/InternalAPI/WebGPUBuffer.h
    M Source/WebKit/GPUProcess/graphics/WebGPU/RemoteBuffer.cpp
    M Source/WebKit/WebProcess/GPU/graphics/WebGPU/RemoteBufferProxy.cpp
    M Source/WebKit/WebProcess/GPU/graphics/WebGPU/RemoteBufferProxy.h

  Log Message:
  -----------
  [WebGPU] UAF in GPUBuffer::getMappedRange
https://bugs.webkit.org/show_bug.cgi?id=273685
<radar://127490690>

Reviewed by Dan Glastonbury.

Fix UAF by using a callback and update test expectations to run
in Debug which would have likely caught this issue.

* LayoutTests/platform/mac-wk2/TestExpectations:
* Source/WebCore/Modules/WebGPU/GPUBuffer.cpp:
(WebCore::GPUBuffer::getMappedRange):
* Source/WebCore/Modules/WebGPU/Implementation/WebGPUBufferImpl.cpp:
(WebCore::WebGPU::BufferImpl::getMappedRange):
* Source/WebCore/Modules/WebGPU/Implementation/WebGPUBufferImpl.h:
* Source/WebCore/Modules/WebGPU/InternalAPI/WebGPUBuffer.h:
* Source/WebKit/WebProcess/GPU/graphics/WebGPU/RemoteBufferProxy.cpp:
(WebKit::WebGPU::RemoteBufferProxy::getMappedRange):
* Source/WebKit/WebProcess/GPU/graphics/WebGPU/RemoteBufferProxy.h:

Canonical link: https://commits.webkit.org/278392@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications