[webkit-changes] [WebKit/WebKit] 9e40c1: Optimize some usage of StringBuilder

[Chris Dumez]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 9e40c12adba07ed27e7bd52bb32cfedcb1eef2aa
      https://github.com/WebKit/WebKit/commit/9e40c12adba07ed27e7bd52bb32cfedcb1eef2aa
  Author: Chris Dumez <cdumez at apple.com>
  Date:   2024-05-04 (Sat, 04 May 2024)

  Changed paths:
    M Source/JavaScriptCore/runtime/FileBasedFuzzerAgentBase.cpp
    M Source/WTF/wtf/URL.cpp
    M Source/WTF/wtf/text/WTFString.cpp
    M Source/WebCore/Modules/encryptedmedia/MediaKeySession.cpp
    M Source/WebCore/Modules/entriesapi/DOMFileSystem.cpp
    M Source/WebCore/Modules/geolocation/Geolocation.cpp
    M Source/WebCore/Modules/indexeddb/IDBKeyData.cpp
    M Source/WebCore/Modules/indexeddb/IDBKeyPath.cpp
    M Source/WebCore/Modules/push-api/PushSubscriptionIdentifier.cpp
    M Source/WebCore/PAL/pal/text/DecodeEscapeSequences.h
    M Source/WebCore/css/CSSCounterStyleDescriptors.cpp
    M Source/WebCore/css/CSSStyleRule.cpp
    M Source/WebCore/css/query/GenericMediaQuerySerialization.cpp
    M Source/WebCore/css/typedom/CSSOMVariableReferenceValue.cpp
    M Source/WebCore/css/typedom/transform/CSSMatrixComponent.cpp
    M Source/WebCore/dom/FragmentDirectiveGenerator.cpp
    M Source/WebCore/editing/FontShadow.cpp
    M Source/WebCore/inspector/InspectorOverlay.cpp
    M Source/WebCore/loader/ResourceLoadStatistics.cpp
    M Source/WebCore/loader/archive/mhtml/MHTMLArchive.cpp
    M Source/WebCore/platform/graphics/CodecUtilities.cpp
    M Source/WebCore/platform/graphics/MediaPlayer.cpp
    M Source/WebCore/platform/graphics/VP9Utilities.cpp
    M Source/WebCore/platform/gtk/SelectionData.cpp
    M Source/WebCore/platform/mediarecorder/MediaRecorderPrivateMock.cpp
    M Source/WebCore/platform/network/curl/NetworkStorageSessionCurl.cpp
    M Source/WebCore/platform/text/win/LocaleWin.cpp
    M Source/WebCore/testing/Internals.cpp
    M Source/WebGPU/WGSL/Metal/MetalFunctionWriter.cpp
    M Source/WebGPU/WGSL/Parser.cpp
    M Source/WebKit/NetworkProcess/cocoa/NetworkSessionCocoa.mm
    M Source/WebKit/NetworkProcess/storage/CacheStorageManager.cpp
    M Source/WebKit/NetworkProcess/storage/NetworkStorageManager.cpp

  Log Message:
  -----------
  Optimize some usage of StringBuilder
https://bugs.webkit.org/show_bug.cgi?id=273728

Reviewed by Tim Nguyen.

Optimize some usage of StringBuilder. This is a follow-up to 278348 at main
to address Darin's comments.

* Source/JavaScriptCore/runtime/FileBasedFuzzerAgentBase.cpp:
(JSC::FileBasedFuzzerAgentBase::createLookupKey):
* Source/WTF/wtf/URL.cpp:
(WTF::percentEncodeCharacters):
* Source/WTF/wtf/text/WTFString.cpp:
(asciiDebug):
* Source/WebCore/Modules/encryptedmedia/MediaKeySession.cpp:
(WebCore::MediaKeySession::updateKeyStatuses):
* Source/WebCore/Modules/entriesapi/DOMFileSystem.cpp:
(WebCore::resolveRelativeVirtualPath):
* Source/WebCore/Modules/geolocation/Geolocation.cpp:
(WebCore::logError):
* Source/WebCore/Modules/indexeddb/IDBKeyData.cpp:
(WebCore::IDBKeyData::loggingString const):
* Source/WebCore/Modules/indexeddb/IDBKeyPath.cpp:
(WebCore::loggingString):
* Source/WebCore/Modules/push-api/PushSubscriptionIdentifier.cpp:
(WebCore::PushSubscriptionSetIdentifier::debugDescription const):
* Source/WebCore/PAL/pal/text/DecodeEscapeSequences.h:
(PAL::decodeEscapeSequences):
* Source/WebCore/css/CSSCounterStyleDescriptors.cpp:
(WebCore::CSSCounterStyleDescriptors::symbolsCSSText const):
(WebCore::CSSCounterStyleDescriptors::additiveSymbolsCSSText const):
* Source/WebCore/css/CSSStyleRule.cpp:
(WebCore::CSSStyleRule::cssTextInternal const):
* Source/WebCore/css/query/GenericMediaQuerySerialization.cpp:
(WebCore::MQ::serialize):
* Source/WebCore/css/typedom/CSSOMVariableReferenceValue.cpp:
(WebCore::CSSOMVariableReferenceValue::serialize const):
* Source/WebCore/css/typedom/transform/CSSMatrixComponent.cpp:
(WebCore::CSSMatrixComponent::serialize const):
* Source/WebCore/dom/FragmentDirectiveGenerator.cpp:
(WebCore::FragmentDirectiveGenerator::generateFragmentDirective):
* Source/WebCore/editing/FontShadow.cpp:
(WebCore::serializationForCSS):
* Source/WebCore/inspector/InspectorOverlay.cpp:
(WebCore::InspectorOverlay::buildFlexOverlay):
* Source/WebCore/loader/ResourceLoadStatistics.cpp:
(WebCore::ResourceLoadStatistics::toString const):
* Source/WebCore/loader/archive/mhtml/MHTMLArchive.cpp:
(WebCore::MHTMLArchive::generateMHTMLData):
* Source/WebCore/platform/graphics/CodecUtilities.cpp:
(WebCore::humanReadableStringFromCodecString):
* Source/WebCore/platform/graphics/MediaPlayer.cpp:
(WebCore::SeekTarget::toString const):
* Source/WebCore/platform/graphics/VP9Utilities.cpp:
(WebCore::createVPCodecParametersString):
* Source/WebCore/platform/graphics/texmap/TextureMapperShaderProgram.cpp:
(WebCore::TextureMapperShaderProgram::create):
* Source/WebCore/platform/gtk/SelectionData.cpp:
(WebCore::SelectionData::setURL):
* Source/WebCore/platform/mediarecorder/MediaRecorderPrivateMock.cpp:
(WebCore::MediaRecorderPrivateMock::videoFrameAvailable):
(WebCore::MediaRecorderPrivateMock::audioSamplesAvailable):
* Source/WebCore/platform/network/curl/NetworkStorageSessionCurl.cpp:
(WebCore::cookiesForSession):
* Source/WebCore/platform/text/win/LocaleWin.cpp:
(WebCore::LocaleWin::shortTimeFormat):
(WebCore::LocaleWin::dateTimeFormatWithSeconds):
(WebCore::LocaleWin::dateTimeFormatWithoutSeconds):
* Source/WebCore/testing/Internals.cpp:
(WebCore::Internals::imageLastDecodingOptions):
(WebCore::Internals::dumpStyleResolvers):
* Source/WebGPU/WGSL/Metal/MetalFunctionWriter.cpp:
(WGSL::Metal::FunctionDefinitionWriter::emitNecessaryHelpers):
(WGSL::Metal::FunctionDefinitionWriter::visit):
(WGSL::Metal::FunctionDefinitionWriter::generatePackingHelpers):
(WGSL::Metal::FunctionDefinitionWriter::emitPackedVector):
* Source/WebGPU/WGSL/Parser.cpp:
* Source/WebKit/NetworkProcess/cocoa/NetworkSessionCocoa.mm:
(WebKit::NetworkSessionCocoa::donateToSKAdNetwork):
* Source/WebKit/NetworkProcess/storage/CacheStorageManager.cpp:
(WebKit::CacheStorageManager::representationString):
* Source/WebKit/NetworkProcess/storage/NetworkStorageManager.cpp:
(WebKit::NetworkStorageManager::cacheStorageRepresentation):

Canonical link: https://commits.webkit.org/278383@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications