[webkit-changes] [WebKit/WebKit] 585ea5: REGRESSION (278276 at main): Crash when collecting Tr...

[megangardner]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 585ea5ce731bd4f65e124ce2e0271a78796413dd
      https://github.com/WebKit/WebKit/commit/585ea5ce731bd4f65e124ce2e0271a78796413dd
  Author: Megan Gardner <megan_gardner at apple.com>
  Date:   2024-05-03 (Fri, 03 May 2024)

  Changed paths:
    M Source/WebCore/dom/DocumentMarkerController.cpp
    M Source/WebCore/rendering/MarkedText.cpp
    M Source/WebCore/rendering/MarkedText.h
    M Source/WebCore/rendering/RenderText.cpp
    M Source/WebCore/rendering/RenderText.h
    M Source/WebCore/rendering/TextBoxPainter.cpp

  Log Message:
  -----------
  REGRESSION (278276 at main): Crash when collecting Transparent DocumentMarkers.
https://bugs.webkit.org/show_bug.cgi?id=273710
rdar://127511853

Reviewed by Wenson Hsieh.

Original implementation of transparent document markers
was incorrect and resulted in a WebProcess crash. They
need to be closer to draggedContent markers (which I hope
to combine them with someday) and be gathered and added
separately so they can work with selection.

* Source/WebCore/dom/DocumentMarkerController.cpp:
(WebCore::shouldInsertAsSeparateMarker):
* Source/WebCore/rendering/MarkedText.cpp:
(WebCore::MarkedText::collectForDocumentMarkers):
(WebCore::MarkedText::collectForDraggedAndTransparentType):
(WebCore::MarkedText::collectForDraggedContent): Deleted.
* Source/WebCore/rendering/MarkedText.h:
* Source/WebCore/rendering/RenderText.cpp:
(WebCore::RenderText::contentRangesBetweenOffsetsForType const):
(WebCore::RenderText::draggedContentRangesBetweenOffsets const): Deleted.
* Source/WebCore/rendering/RenderText.h:
* Source/WebCore/rendering/TextBoxPainter.cpp:
(WebCore::TextBoxPainter<TextBoxPath>::paintForegroundAndDecorations):
(WebCore::TextBoxPainter<TextBoxPath>::paintForeground):

Canonical link: https://commits.webkit.org/278363@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications