[webkit-changes] [WebKit/WebKit] 6d8b44: [Legacy line layout removal] Stop measuring text i...

[Antti Koivisto]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 6d8b441bc01730b462d5f6f3c18e9cbd3e8956f0
      https://github.com/WebKit/WebKit/commit/6d8b441bc01730b462d5f6f3c18e9cbd3e8956f0
  Author: Antti Koivisto <antti at apple.com>
  Date:   2024-05-03 (Fri, 03 May 2024)

  Changed paths:
    M LayoutTests/platform/glib/svg/batik/text/xmlSpace-expected.txt
    M LayoutTests/platform/ios/svg/batik/text/xmlSpace-expected.txt
    M LayoutTests/platform/mac/svg/batik/text/xmlSpace-expected.txt
    M Source/WebCore/rendering/LegacyLineLayout.cpp
    M Source/WebCore/rendering/LegacyLineLayout.h
    M Source/WebCore/rendering/line/BreakingContext.h
    M Source/WebCore/rendering/line/LineBreaker.cpp
    M Source/WebCore/rendering/line/LineBreaker.h

  Log Message:
  -----------
  [Legacy line layout removal] Stop measuring text in BreakingContext
https://bugs.webkit.org/show_bug.cgi?id=273614
rdar://127416332

Reviewed by Alan Baradlay and Sam Weinig.

SVG doesn't break lines so there is no need to measure.

* LayoutTests/platform/ios/svg/batik/text/xmlSpace-expected.txt:
* LayoutTests/platform/mac/svg/batik/text/xmlSpace-expected.txt:

Non-visual change (we create an inline box for empty inline whereas previously we didn't)

* Source/WebCore/rendering/LegacyLineLayout.cpp:
(WebCore::LegacyLineLayout::layoutRunsAndFloatsInRange):
* Source/WebCore/rendering/LegacyLineLayout.h:
* Source/WebCore/rendering/line/BreakingContext.h:
(WebCore::BreakingContext::handleText):
(WebCore::WordMeasurement::WordMeasurement): Deleted.
(WebCore::firstPositiveWidth): Deleted.
(WebCore::textWidth): Deleted.
(WebCore::BreakingContext::textWidthConsideringPossibleTrailingSpace): Deleted.
(WebCore::BreakingContext::computeAdditionalBetweenWordsWidth): Deleted.
* Source/WebCore/rendering/line/LineBreaker.cpp:
(WebCore::LineBreaker::nextLineBreak):
* Source/WebCore/rendering/line/LineBreaker.h:

Canonical link: https://commits.webkit.org/278360@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications