[webkit-changes] [WebKit/WebKit] 25b857: [WebGPU] RenderBundleEncoder::setPipeline replay c...
mwyrzykowski
noreply at github.com
Fri May 3 18:12:13 PDT 2024
Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 25b857296fadedbda2bfc9d957537b46338149e4
https://github.com/WebKit/WebKit/commit/25b857296fadedbda2bfc9d957537b46338149e4
Author: Mike Wyrzykowski <mwyrzykowski at apple.com>
Date: 2024-05-03 (Fri, 03 May 2024)
Changed paths:
M LayoutTests/TestExpectations
A LayoutTests/fast/webgpu/fuzz-273578-expected.txt
A LayoutTests/fast/webgpu/fuzz-273578.html
M Source/WebGPU/WebGPU/RenderBundleEncoder.mm
M Source/WebGPU/WebGPU/RenderPassEncoder.h
M Source/WebGPU/WebGPU/RenderPassEncoder.mm
Log Message:
-----------
[WebGPU] RenderBundleEncoder::setPipeline replay command should call into RenderPassEncoder
https://bugs.webkit.org/show_bug.cgi?id=273578
<radar://127229686>
Reviewed by Dan Glastonbury.
We were not validating setPipeline calls in ICBs leading
to metal validation errors in invalid usage scenarios.
* LayoutTests/TestExpectations:
* LayoutTests/fast/webgpu/fuzz-273578-expected.txt: Added.
* LayoutTests/fast/webgpu/fuzz-273578.html: Added.
Add regression tests.
* Source/WebGPU/WebGPU/RenderBundleEncoder.mm:
(WebGPU::RenderBundleEncoder::setPipeline):
Class helper.
* Source/WebGPU/WebGPU/RenderPassEncoder.h:
Introduce helper.
* Source/WebGPU/WebGPU/RenderPassEncoder.mm:
(WebGPU::RenderPassEncoder::errorValidatingPipeline const):
(WebGPU::RenderPassEncoder::setPipeline):
Call helper.
Canonical link: https://commits.webkit.org/278357@main
To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications
More information about the webkit-changes
mailing list