[webkit-changes] [WebKit/WebKit] 0470d0: REGRESSION (iOS 17.4.1?): <video> tag fails to adj...
Eric Carlson
noreply at github.com
Fri May 3 17:20:24 PDT 2024
Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 0470d0f338da5e4a677552edd1f13f7549159271
https://github.com/WebKit/WebKit/commit/0470d0f338da5e4a677552edd1f13f7549159271
Author: Eric Carlson <eric.carlson at apple.com>
Date: 2024-05-03 (Fri, 03 May 2024)
Changed paths:
M Source/WebKit/UIProcess/Cocoa/VideoPresentationManagerProxy.mm
Log Message:
-----------
REGRESSION (iOS 17.4.1?): <video> tag fails to adjust its size according to changes in the parent element
https://bugs.webkit.org/show_bug.cgi?id=272078
rdar://125881482
Reviewed by Jer Noble.
When layout changes the size of a remote-hosted video element with a MediaStream
source, the order of calls to `VideoPresentationManagerProxy` and
`VideoPresentationModelContext` isn't always the same. If
`VideoPresentationManagerProxy::createViewWithID` is called before the model's
view has been created, it creates and configures a WebAVPlayerLayerView and
a WKVideoView. It did not set the model's video dimensions, which sometimes
caused WebAVPlayerLayer to be resized incorrectly when layout changed the
size of the video element very quickly.
* Source/WebKit/UIProcess/Cocoa/VideoPresentationManagerProxy.mm:
(WebKit::VideoPresentationManagerProxy::createViewWithID): Call model->setVideoDimensions
with the video's native dimensions.
Canonical link: https://commits.webkit.org/278350@main
To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications
More information about the webkit-changes
mailing list