[webkit-changes] [WebKit/WebKit] c53d43: [Unified Text Replacement] When a "rich text" text...

Richard Robinson noreply at github.com
Fri May 3 14:46:40 PDT 2024


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: c53d438a8fed8e5c2a8ca63d7e5c900ee9d24967
      https://github.com/WebKit/WebKit/commit/c53d438a8fed8e5c2a8ca63d7e5c900ee9d24967
  Author: Richard Robinson <richard_robinson2 at apple.com>
  Date:   2024-05-03 (Fri, 03 May 2024)

  Changed paths:
    M Source/WebKit/WebProcess/WebPage/Cocoa/UnifiedTextReplacementController.mm
    M Source/WebKit/WebProcess/WebPage/UnifiedTextReplacementController.h

  Log Message:
  -----------
  [Unified Text Replacement] When a "rich text" text replacement session ends, the session should be undone if it is not accepted
https://bugs.webkit.org/show_bug.cgi?id=273709
rdar://127390343

Reviewed by Abrar Rahman Protyasha.

Ensure that `didEndTextReplacementSession` handles both plain text and rich text replacements properly.

* Source/WebKit/WebProcess/WebPage/Cocoa/UnifiedTextReplacementController.mm:
(WebKit::UnifiedTextReplacementController::didEndTextReplacementSession<WebUnifiedTextReplacementType::PlainText>):
(WebKit::UnifiedTextReplacementController::didEndTextReplacementSession<WebUnifiedTextReplacementType::RichText>):
(WebKit::UnifiedTextReplacementController::didEndTextReplacementSession):
* Source/WebKit/WebProcess/WebPage/UnifiedTextReplacementController.h:

Canonical link: https://commits.webkit.org/278345@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications


More information about the webkit-changes mailing list