[webkit-changes] [WebKit/WebKit] 6126d8: [Site Isolation] Begin considering iframe navigati...

[Charlie Wolfe]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 6126d87e8020993596d13f1fc39c5803dbcadd40
      https://github.com/WebKit/WebKit/commit/6126d87e8020993596d13f1fc39c5803dbcadd40
  Author: Charlie Wolfe <charliew at apple.com>
  Date:   2024-05-03 (Fri, 03 May 2024)

  Changed paths:
    M Source/WebCore/loader/HistoryController.cpp
    M Source/WebKit/UIProcess/WebPageProxy.cpp
    M Tools/TestWebKitAPI/Tests/WebKitCocoa/SiteIsolation.mm

  Log Message:
  -----------
  [Site Isolation] Begin considering iframe navigations in the back-forward list
https://bugs.webkit.org/show_bug.cgi?id=273669
rdar://127471573

Reviewed by Alex Christensen.

When an iframe is initially loaded with site isolation disabled, `LockBackForwardList::Yes` is set on the
frame load request to indicate that the back-forward list should not be updated. We should do the same
when loading an iframe in a new process. Also, remove an unnecessary return that causes any isolated
frame navigation to be ignored.

The test verifies that `canGoBack` returns false after initially loading a cross-origin iframe, but
returns true after the iframe navigates.

* Source/WebCore/loader/HistoryController.cpp:
(WebCore::HistoryController::updateBackForwardListClippedAtTarget):
* Source/WebKit/UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::continueNavigationInNewProcess):
* Tools/TestWebKitAPI/Tests/WebKitCocoa/SiteIsolation.mm:
(TestWebKitAPI::TEST(SiteIsolation, CanGoBackAfterLoadingAndNavigatingFrame)):

Canonical link: https://commits.webkit.org/278333@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications