[webkit-changes] [WebKit/WebKit] 252452: REGRESSION (274409 at main): [ macOS wk2 ] 2 tests in...

Matthew Finkel noreply at github.com
Fri May 3 09:57:21 PDT 2024


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 252452ae30653f87ce0c6d9f6fb21cbb68df1dfd
      https://github.com/WebKit/WebKit/commit/252452ae30653f87ce0c6d9f6fb21cbb68df1dfd
  Author: Matthew Finkel <sysrqb at apple.com>
  Date:   2024-05-03 (Fri, 03 May 2024)

  Changed paths:
    M LayoutTests/http/tests/navigation/ping-attribute/area-cross-origin-from-https-UpgradeMixedContent.html
    M LayoutTests/http/tests/navigation/ping-attribute/area-cross-origin-from-https.html
    M LayoutTests/platform/mac-wk2/TestExpectations

  Log Message:
  -----------
  REGRESSION (274409 at main): [ macOS wk2 ] 2 tests in http/tests/navigation/ping-attribute are flaky
https://bugs.webkit.org/show_bug.cgi?id=269798
rdar://123321229

Reviewed by Charlie Wolfe.

These tests have been flakey since 274409 at main. Apparently there's a race
condition between the the xhr request that deletes any stale pings and the
script-based location redirect. This change attempts to avoid that issue by
only deleting cookies if we're not going to load a different page.

* LayoutTests/http/tests/navigation/ping-attribute/area-cross-origin-from-https-UpgradeMixedContent.html:
* LayoutTests/http/tests/navigation/ping-attribute/area-cross-origin-from-https.html:
* LayoutTests/platform/mac-wk2/TestExpectations:

Canonical link: https://commits.webkit.org/278329@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications


More information about the webkit-changes mailing list