[webkit-changes] [WebKit/WebKit] 3f1a72: [webkitpy] Make Executive.kill_process more reliable.

Ben noreply at github.com
Fri May 3 02:17:11 PDT 2024


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 3f1a725ef3d3f0a0ee05b56aff41fbfdae90f34f
      https://github.com/WebKit/WebKit/commit/3f1a725ef3d3f0a0ee05b56aff41fbfdae90f34f
  Author: Ben Schwartz <ben_schwartz at apple.com>
  Date:   2024-05-03 (Fri, 03 May 2024)

  Changed paths:
    M Tools/Scripts/webkitpy/common/system/executive.py

  Log Message:
  -----------
  [webkitpy] Make Executive.kill_process more reliable.
rdar://127407344
https://bugs.webkit.org/show_bug.cgi?id=273652

Reviewed by Ryan Haddad and Jonathan Bedard.

Executive.kill_process currently tries to exit with SIGTERM once and then jumps straight to
SIGKILL. This can leave leftover processes, as SIGKILL sometimes doesn't give processes
enough time to react in the way that SIGTERM does.

* Tools/Scripts/webkitpy/common/system/executive.py:
(Executive.kill_process): Add more retries and wait 0.05 seconds after each.

Canonical link: https://commits.webkit.org/278309@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications


More information about the webkit-changes mailing list