[webkit-changes] [WebKit/WebKit] c368b1: [WebGPU] useResources: should not be called on emp...

[mwyrzykowski]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: c368b1bcceb094886be6b37a8c21035280ce6782
      https://github.com/WebKit/WebKit/commit/c368b1bcceb094886be6b37a8c21035280ce6782
  Author: Mike Wyrzykowski <mwyrzykowski at apple.com>
  Date:   2024-05-02 (Thu, 02 May 2024)

  Changed paths:
    M LayoutTests/TestExpectations
    A LayoutTests/fast/webgpu/fuzz-273505-expected.txt
    A LayoutTests/fast/webgpu/fuzz-273505.html
    M Source/WebGPU/WebGPU/BindGroup.mm
    M Source/WebGPU/WebGPU/CommandEncoder.mm
    M Source/WebGPU/WebGPU/ComputePassEncoder.mm
    M Source/WebGPU/WebGPU/Queue.mm
    M Source/WebGPU/WebGPU/RenderBundleEncoder.h
    M Source/WebGPU/WebGPU/RenderBundleEncoder.mm
    M Source/WebGPU/WebGPU/RenderPassEncoder.mm

  Log Message:
  -----------
  [WebGPU] useResources: should not be called on empty resource list
https://bugs.webkit.org/show_bug.cgi?id=273505
<radar://127230835>

Reviewed by Dan Glastonbury.

Add additional validation to some render bundle commands
and writeTexture calls to ensure no metal validation errors occur
at runtime.

Confirmed no regressions to api CTS tests.

* LayoutTests/TestExpectations:
* LayoutTests/fast/webgpu/fuzz-273505-expected.txt: Added.
* LayoutTests/fast/webgpu/fuzz-273505.html: Added.
Add regression test.

* Source/WebGPU/WebGPU/BindGroup.mm:
(WebGPU::Device::createBindGroup):
* Source/WebGPU/WebGPU/CommandEncoder.mm:
(WebGPU::hasZeroDimension):
(WebGPU::CommandEncoder::copyTextureToBuffer):
* Source/WebGPU/WebGPU/ComputePassEncoder.mm:
(WebGPU::ComputePassEncoder::setBindGroup):
* Source/WebGPU/WebGPU/Queue.mm:
(WebGPU::Queue::writeTexture):
* Source/WebGPU/WebGPU/RenderBundleEncoder.h:
* Source/WebGPU/WebGPU/RenderBundleEncoder.mm:
(WebGPU::makeRenderBundleICBWithResources):
(WebGPU::RenderBundleEncoder::draw):
(WebGPU::RenderBundleEncoder::finalizeRenderCommand):
(WebGPU::RenderBundleEncoder::drawIndexed):
(WebGPU::RenderBundleEncoder::drawIndexedIndirect):
(WebGPU::RenderBundleEncoder::drawIndirect):
(WebGPU::RenderBundleEncoder::endCurrentICB):
(WebGPU::RenderBundleEncoder::setBindGroup):
(WebGPU::RenderBundleEncoder::setIndexBuffer):
(WebGPU::RenderBundleEncoder::setPipeline):
(wgpuRenderBundleEncoderDrawIndexedIndirect):
(wgpuRenderBundleEncoderDrawIndirect):
* Source/WebGPU/WebGPU/RenderPassEncoder.mm:
(WebGPU::RenderPassEncoder::executeBundles):
(WebGPU::RenderPassEncoder::setBindGroup):

Canonical link: https://commits.webkit.org/278300@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications