[webkit-changes] [WebKit/WebKit] 593a44: [UnifedPDF] Occasional crash at GraphicsLayerCA::s...

[Simon Fraser]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 593a44258e5e7a802caee79c99b7a31c807bb029
      https://github.com/WebKit/WebKit/commit/593a44258e5e7a802caee79c99b7a31c807bb029
  Author: Simon Fraser <simon.fraser at apple.com>
  Date:   2024-05-02 (Thu, 02 May 2024)

  Changed paths:
    M Source/WebKit/WebProcess/Plugins/PDF/UnifiedPDF/UnifiedPDFPlugin.mm

  Log Message:
  -----------
  [UnifedPDF] Occasional crash at GraphicsLayerCA::setNeedsDisplayInRect() with slow-rendering PDFs
https://bugs.webkit.org/show_bug.cgi?id=273661
rdar://127443945

Reviewed by Abrar Rahman Protyasha.

We should use `unparentAndClear()` on the GraphicsLayers to both unparent them, and clear their
GraphicsLayerClient. Do this on the layers which draw content, since those are the ones whose
clients can get called after a delay.

* Source/WebKit/WebProcess/Plugins/PDF/UnifiedPDF/UnifiedPDFPlugin.mm:
(WebKit::UnifiedPDFPlugin::teardown):

Canonical link: https://commits.webkit.org/278298@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications