[webkit-changes] [WebKit/WebKit] 6739e6: Remove nsStringFromWebCoreString in favor of Strin...

[Alex Christensen]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 6739e68573c53703077bdeb5c7c986e8130d7bc5
      https://github.com/WebKit/WebKit/commit/6739e68573c53703077bdeb5c7c986e8130d7bc5
  Author: Alex Christensen <achristensen at apple.com>
  Date:   2024-05-02 (Thu, 02 May 2024)

  Changed paths:
    M Source/WebKit/NetworkProcess/mac/NetworkProcessMac.mm
    M Source/WebKit/Platform/mac/StringUtilities.h
    M Source/WebKit/Platform/mac/StringUtilities.mm
    M Source/WebKit/UIProcess/API/C/mac/WKContextPrivateMac.mm
    M Source/WebKit/UIProcess/Cocoa/WebPreferencesCocoa.mm
    M Source/WebKit/UIProcess/ios/PageClientImplIOS.mm
    M Source/WebKit/UIProcess/mac/PageClientImplMac.mm
    M Source/WebKit/UIProcess/mac/WebPageProxyMac.mm
    M Source/WebKit/UIProcess/mac/WebPopupMenuProxyMac.mm
    M Source/WebKit/UIProcess/mac/WebViewImpl.mm
    M Source/WebKit/WebProcess/WebCoreSupport/WebPlatformStrategies.cpp

  Log Message:
  -----------
  Remove nsStringFromWebCoreString in favor of String::operator NSString*
https://bugs.webkit.org/show_bug.cgi?id=273567
rdar://127285782

Reviewed by Geoffrey Garen.

Its name was not accurate, the comment was moved with it 12 years ago and isn't accurate any more.
Just remove some old code and use simpler equivalent code.

* Source/WebKit/NetworkProcess/mac/NetworkProcessMac.mm:
* Source/WebKit/Platform/mac/StringUtilities.h:
* Source/WebKit/Platform/mac/StringUtilities.mm:
(WebKit::nsStringFromWebCoreString): Deleted.
* Source/WebKit/UIProcess/API/C/mac/WKContextPrivateMac.mm:
* Source/WebKit/UIProcess/Cocoa/WebPreferencesCocoa.mm:
(WebKit::WebPreferences::platformUpdateStringValueForKey):
* Source/WebKit/UIProcess/ios/PageClientImplIOS.mm:
* Source/WebKit/UIProcess/mac/PageClientImplMac.mm:
(WebKit::PageClientImpl::handleControlledElementIDResponse):
* Source/WebKit/UIProcess/mac/WebPageProxyMac.mm:
(WebKit::WebPageProxy::speak):
* Source/WebKit/UIProcess/mac/WebPopupMenuProxyMac.mm:
(WebKit::WebPopupMenuProxyMac::populate):
* Source/WebKit/UIProcess/mac/WebViewImpl.mm:
(WebKit::WebViewImpl::stringForToolTip):
* Source/WebKit/WebProcess/WebCoreSupport/WebPlatformStrategies.cpp:

Canonical link: https://commits.webkit.org/278278@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications