[webkit-changes] [WebKit/WebKit] 244f3f: [JSC] Keeping Identifiers in PolymorphicAccessJITS...

[Yusuke Suzuki]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 244f3f7a26912913b7997a11911a44ebaf761865
      https://github.com/WebKit/WebKit/commit/244f3f7a26912913b7997a11911a44ebaf761865
  Author: Yusuke Suzuki <ysuzuki at apple.com>
  Date:   2024-05-02 (Thu, 02 May 2024)

  Changed paths:
    M Source/JavaScriptCore/jit/GCAwareJITStubRoutine.cpp
    M Source/JavaScriptCore/jit/GCAwareJITStubRoutine.h

  Log Message:
  -----------
  [JSC] Keeping Identifiers in PolymorphicAccessJITStubRoutine is not necessary
https://bugs.webkit.org/show_bug.cgi?id=273610
rdar://127411952

Reviewed by Justin Michaud.

We are using shared JIT stub only for Baseline JIT IC, and ById case with Baseline JIT IC always has
CodeBlock which holds CacheableIdentifier. So JIT stub itself does not need to keep them.
When the stub is no longer used, then it gets zero-ref-count, and removed from shared JIT stub table automatically.

* Source/JavaScriptCore/jit/GCAwareJITStubRoutine.cpp:
(JSC::PolymorphicAccessJITStubRoutine::addedToSharedJITStubSet):
* Source/JavaScriptCore/jit/GCAwareJITStubRoutine.h:

Canonical link: https://commits.webkit.org/278268@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications