[webkit-changes] [WebKit/WebKit] 90471a: AX: accessibility/mac/resolved-text-editing.html c...

AndresGonzalezApple noreply at github.com
Thu May 2 07:25:55 PDT 2024


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 90471a0870d621abcaa9b61938a2c933ec93121c
      https://github.com/WebKit/WebKit/commit/90471a0870d621abcaa9b61938a2c933ec93121c
  Author: Andres Gonzalez <andresg_22 at apple.com>
  Date:   2024-05-02 (Thu, 02 May 2024)

  Changed paths:
    M LayoutTests/accessibility-isolated-tree/TestExpectations
    M LayoutTests/accessibility/mac/resolved-text-editing-expected.txt
    M LayoutTests/accessibility/mac/resolved-text-editing.html
    M Tools/WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm

  Log Message:
  -----------
  AX: accessibility/mac/resolved-text-editing.html crashes intermittently in isolated tree mode.
https://bugs.webkit.org/show_bug.cgi?id=273548
<rdar://problem/127358393>

Reviewed by Tyler Wilcock.

The dispatch to the AX thread in AccessibilityUIElement::attributeValueAsync has to be synchronous, otherwise the callback function goes out of scope and causes the crash when invoked.
Cleaned up the test to adhere to AX test standards.

* LayoutTests/accessibility-isolated-tree/TestExpectations:
* LayoutTests/accessibility/mac/resolved-text-editing-expected.txt:
* LayoutTests/accessibility/mac/resolved-text-editing.html:
* Tools/WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
(WTR::AccessibilityUIElement::attributeValueAsync):

Canonical link: https://commits.webkit.org/278255@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications


More information about the webkit-changes mailing list