[webkit-changes] [WebKit/WebKit] b632e2: [visionOS] Add SPI module for LinearMediaKit
Elliott Williams
noreply at github.com
Wed May 1 14:58:11 PDT 2024
Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: b632e2a90f9fc8d6894b80700dd023965cdd5ad6
https://github.com/WebKit/WebKit/commit/b632e2a90f9fc8d6894b80700dd023965cdd5ad6
Author: Elliott Williams <emw at apple.com>
Date: 2024-05-01 (Wed, 01 May 2024)
Changed paths:
M Source/WebKit/Configurations/WebKitSwift.xcconfig
A Source/WebKit/Platform/spi/visionos/LinearMediaKit.swiftinterface
M Source/WebKit/WebKitSwift/LinearMediaKit/WKSLinearMediaPlayer.h
M Source/WebKit/WebKitSwift/WebKitSwift.h
Log Message:
-----------
[visionOS] Add SPI module for LinearMediaKit
rdar://127327242
https://bugs.webkit.org/show_bug.cgi?id=273527
Reviewed by Andy Estes.
In order to build visionOS using the public SDK, WebKitSwift needs to
`import LinearMediaKit`, which a private framework. For C-family
framework we'd handle this by adding an SPI header, to go with
auto-extracted TBDs in WebKitLibraries/. But because this is a Swift
framework, we need an alternative.
Add a handwritten LinearMediaKit.swiftinterface file to the relevant spi
directory. This contains the subset of the framework that WebKit links
against. In public SDK builds, SWIFT_INCLUDE_PATHS is modified to
include this directory, making the module importable in public while
falling back to the private framework's module internally.
* Source/WebKit/Configurations/WebKitSwift.xcconfig:
* Source/WebKit/Platform/spi/visionos/LinearMediaKit.swiftinterface: Added.
* Source/WebKit/WebKitSwift/LinearMediaKit/WKSLinearMediaPlayer.h: In
public builds, WebKitSwift does not implicitly have libxpc imported,
so add an import of XPCSPI.h.
* Source/WebKit/WebKitSwift/WebKitSwift.h: LinearMediaKitSPI.h doesn't
need to be in private headers, as it's only used by WebKit itself.
Fixes a TAPI error.
Canonical link: https://commits.webkit.org/278232@main
To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications
More information about the webkit-changes
mailing list