[webkit-changes] [WebKit/WebKit] 84e133: [view-transitions] https://spotify-astro-transitio...

mattwoodrow noreply at github.com
Wed May 1 14:30:43 PDT 2024


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 84e133272f1e3d267014c0b78953c25750b3ed9b
      https://github.com/WebKit/WebKit/commit/84e133272f1e3d267014c0b78953c25750b3ed9b
  Author: Matt Woodrow <mattwoodrow at apple.com>
  Date:   2024-05-01 (Wed, 01 May 2024)

  Changed paths:
    A LayoutTests/imported/w3c/web-platform-tests/css/css-view-transitions/new-content-ancestor-clipped-expected.html
    A LayoutTests/imported/w3c/web-platform-tests/css/css-view-transitions/new-content-ancestor-clipped-ref.html
    A LayoutTests/imported/w3c/web-platform-tests/css/css-view-transitions/new-content-ancestor-clipped.html
    M Source/WebCore/rendering/RenderLayerBacking.cpp

  Log Message:
  -----------
  [view-transitions] https://spotify-astro-transitions.vercel.app glitches due to incorrect layer position with overflow:hidden ancestor.
https://bugs.webkit.org/show_bug.cgi?id=273537
<rdar://127340912>

Reviewed by Tim Nguyen.

Rather than just moving the existing parent graphics layer rect (which isn't relevant, since this layer will be reparented),
use the rect that the pseudo (to which this layer will be reparented) represents directly. It still needs to be moved into the coordinate
space of the current compositing ancestor, since that's what the following code expects.

* LayoutTests/imported/w3c/web-platform-tests/css/css-view-transitions/new-content-ancestor-clipped-expected.html: Added.
* LayoutTests/imported/w3c/web-platform-tests/css/css-view-transitions/new-content-ancestor-clipped-ref.html: Added.
* LayoutTests/imported/w3c/web-platform-tests/css/css-view-transitions/new-content-ancestor-clipped.html: Added.
* Source/WebCore/rendering/RenderLayerBacking.cpp:
(WebCore::RenderLayerBacking::updateGeometry):

Canonical link: https://commits.webkit.org/278230@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications


More information about the webkit-changes mailing list