[webkit-changes] [WebKit/WebKit] 1a5937: WebCore::FindOptionFlag should be an enum class

[Abrar Rahman Protyasha]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 1a5937cad8704a64d6edcc79ccab066060d53809
      https://github.com/WebKit/WebKit/commit/1a5937cad8704a64d6edcc79ccab066060d53809
  Author: Abrar Rahman Protyasha <a_protyasha at apple.com>
  Date:   2024-03-30 (Sat, 30 Mar 2024)

  Changed paths:
    M Source/WebCore/accessibility/AccessibilityObject.cpp
    M Source/WebCore/dom/FragmentDirectiveRangeFinder.cpp
    M Source/WebCore/editing/Editor.cpp
    M Source/WebCore/editing/EditorCommand.cpp
    M Source/WebCore/editing/FindOptions.h
    M Source/WebCore/editing/TextIterator.cpp
    M Source/WebCore/editing/TextIterator.h
    M Source/WebCore/page/LocalDOMWindow.cpp
    M Source/WebCore/page/Page.cpp
    M Source/WebCore/testing/Internals.cpp
    M Source/WebKit/Shared/WebFindOptions.cpp
    M Source/WebKit/WebProcess/Plugins/PDF/PDFPlugin.mm
    M Source/WebKit/WebProcess/Plugins/PDF/UnifiedPDF/UnifiedPDFPlugin.mm
    M Source/WebKit/WebProcess/WebPage/Cocoa/WebPageCocoa.mm
    M Source/WebKit/WebProcess/WebPage/FindController.cpp
    M Source/WebKit/WebProcess/WebPage/ios/WebPageIOS.mm
    M Source/WebKitLegacy/mac/WebView/WebView.mm

  Log Message:
  -----------
  WebCore::FindOptionFlag should be an enum class
https://bugs.webkit.org/show_bug.cgi?id=271941
rdar://125667224

Reviewed by Ryosuke Niwa and Charlie Wolfe.

This is a mechanical patch that "enum class"-ifies
WebCore::FindOptionFlag, and takes the liberty to rename the enum to
WebCore::FindOption, which I think is a more fitting name considering
how enum class cases are referenced.

* Source/WebCore/accessibility/AccessibilityObject.cpp:
(WebCore::AccessibilityObject::rangeOfStringClosestToRangeInDirection const):
(WebCore::Accessibility::isAccessibilityTextSearchMatch):
* Source/WebCore/dom/FragmentDirectiveRangeFinder.cpp:
(WebCore::FragmentDirectiveRangeFinder::findRangeFromNodeList):
* Source/WebCore/editing/Editor.cpp:
(WebCore::Editor::findString):
(WebCore::start):
(WebCore::end):
(WebCore::makeBoundaryPointAfterNodeContents):
(WebCore::makeBoundaryPointAfterNode):
(WebCore::Editor::rangeOfString):
(WebCore::Editor::countMatchesForText):
* Source/WebCore/editing/EditorCommand.cpp:
(WebCore::executeFindString):
* Source/WebCore/editing/FindOptions.h:
(): Deleted.
* Source/WebCore/editing/TextIterator.cpp:
(WebCore::SearchBuffer::SearchBuffer):
(WebCore::SearchBuffer::isWordStartMatch const):
(WebCore::SearchBuffer::search):
(WebCore::rangeForMatch):
(WebCore::findClosestPlainText):
(WebCore::findPlainText):
* Source/WebCore/editing/TextIterator.h:
* Source/WebCore/page/LocalDOMWindow.cpp:
(WebCore::LocalDOMWindow::find const):
* Source/WebCore/page/Page.cpp:
(WebCore::Page::findString):
(WebCore::Page::findTextMatches):
(WebCore::Page::rangeOfString):
* Source/WebCore/testing/Internals.cpp:
(WebCore::parseFindOptions):
* Source/WebKit/Shared/WebFindOptions.cpp:
(WebKit::core):
* Source/WebKit/WebProcess/Plugins/PDF/PDFPlugin.mm:
(WebKit::PDFPlugin::countFindMatches):
(WebKit::PDFPlugin::findString):
* Source/WebKit/WebProcess/Plugins/PDF/UnifiedPDF/UnifiedPDFPlugin.mm:
(WebKit::UnifiedPDFPlugin::countFindMatches):
(WebKit::compareOptionsForFindOptions):
(WebKit::UnifiedPDFPlugin::findString):
* Source/WebKit/WebProcess/WebPage/Cocoa/WebPageCocoa.mm:
(WebKit::WebPage::addDictationAlternative):
* Source/WebKit/WebProcess/WebPage/FindController.cpp:
(WebKit::FindController::findString):
* Source/WebKit/WebProcess/WebPage/ios/WebPageIOS.mm:
(WebKit::adjustCandidateAutocorrectionInFrame):
(WebKit::WebPage::applyAutocorrectionInternal):
* Source/WebKitLegacy/mac/WebView/WebView.mm:
(coreOptions):

Canonical link: https://commits.webkit.org/276863@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications