[webkit-changes] [WebKit/WebKit] 70d8c3: [WebGL] remove workaround for multisampled blits t...

[mwyrzykowski]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 70d8c3cd9ea07ff568521b3ca58b488c681e1c22
      https://github.com/WebKit/WebKit/commit/70d8c3cd9ea07ff568521b3ca58b488c681e1c22
  Author: Mike Wyrzykowski <mwyrzykowski at apple.com>
  Date:   2024-03-30 (Sat, 30 Mar 2024)

  Changed paths:
    M LayoutTests/TestExpectations
    M LayoutTests/platform/gtk/TestExpectations
    M LayoutTests/platform/wpe/TestExpectations
    M Source/ThirdParty/ANGLE/src/libANGLE/validationES.cpp
    M Source/WebCore/Modules/webxr/WebXROpaqueFramebuffer.cpp

  Log Message:
  -----------
  [WebGL] remove workaround for multisampled blits to blitFramebuffer
https://bugs.webkit.org/show_bug.cgi?id=271874
<radar://125593588>

Reviewed by Tim Horton.

Root cause here is we were ping-ponging between the resolve
buffer and the main display buffer for copying from the shared
to layered render targets.

The resolve buffer is not multisample, so that copy was fine.

But the display buffer is multisampled, so we would fail Angle
validation and no blit would occur.

Fix this by not destroying the resolve buffer in setupFramebuffer,
revert the Angle change, and also revert skipping blit-framebuffer tests.

* LayoutTests/TestExpectations:
* LayoutTests/platform/gtk/TestExpectations:
* LayoutTests/platform/wpe/TestExpectations:
* Source/ThirdParty/ANGLE/src/libANGLE/validationES.cpp:
(gl::ValidateBlitFramebufferParameters):
* Source/WebCore/Modules/webxr/WebXROpaqueFramebuffer.cpp:
(WebCore::WebXROpaqueFramebuffer::setupFramebuffer):

Canonical link: https://commits.webkit.org/276860@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications