[webkit-changes] [WebKit/WebKit] 55febb: [Mac wk1] http/tests/media/fairplay/fps-mse-play-w...

[Jer Noble]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 55febbbd635cc432b02527966158d2734b9f628a
      https://github.com/WebKit/WebKit/commit/55febbbd635cc432b02527966158d2734b9f628a
  Author: Jer Noble <jer.noble at apple.com>
  Date:   2024-03-29 (Fri, 29 Mar 2024)

  Changed paths:
    M Source/WebCore/platform/graphics/avfoundation/objc/SourceBufferPrivateAVFObjC.mm

  Log Message:
  -----------
  [Mac wk1] http/tests/media/fairplay/fps-mse-play-while-not-in-dom.html is a consistent crash
https://bugs.webkit.org/show_bug.cgi?id=271910
rdar://125380872

Reviewed by Eric Carlson.

In WebKitLegacy, an error can synchronously fire during enqueueSampleBuffer(), which can cause
the HTMLMediaElement to move to an error state, and its MediaSource will subsequently become
disconnected and close. This causes `m_videoRenderer` to become null after a null check.

This should likely be addressed by enqueueing the error to be executed during the next run loop.
Short term, however, is to detect that `m_videoRenderer` has become null and return early.

* Source/WebCore/platform/graphics/avfoundation/objc/SourceBufferPrivateAVFObjC.mm:
(WebCore::SourceBufferPrivateAVFObjC::enqueueSampleBuffer):

Canonical link: https://commits.webkit.org/276848@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications