[webkit-changes] [WebKit/WebKit] 8906cf: AX: Accessibility should not use deprecatedIsSpace...

[Tyler Wilcock]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 8906cfaf11f84fa5e38c678e15741c53b33f307e
      https://github.com/WebKit/WebKit/commit/8906cfaf11f84fa5e38c678e15741c53b33f307e
  Author: Tyler Wilcock <tyler_w at apple.com>
  Date:   2024-03-29 (Fri, 29 Mar 2024)

  Changed paths:
    M LayoutTests/imported/w3c/web-platform-tests/accname/name/comp_text_node-expected.txt
    M Source/WebCore/accessibility/AccessibilityNodeObject.cpp
    M Source/WebCore/accessibility/AccessibilityObject.cpp

  Log Message:
  -----------
  AX: Accessibility should not use deprecatedIsSpaceOrNewline
https://bugs.webkit.org/show_bug.cgi?id=271896
rdar://problem/125621747

Reviewed by Chris Fleizach.

Critically, this function does not include handling non-breaking space characters.

Fixing this allows us to pass 5 more WPT subtests in comp_text_node.html.

* LayoutTests/imported/w3c/web-platform-tests/accname/name/comp_text_node-expected.txt:
* Source/WebCore/accessibility/AccessibilityNodeObject.cpp:
(WebCore::AccessibilityNodeObject::computeAccessibilityIsIgnored const):
(WebCore::AccessibilityNodeObject::textAsLabelFor const):
(WebCore::AccessibilityNodeObject::textUnderElement const):
(WebCore::accessibleNameForNode):
* Source/WebCore/accessibility/AccessibilityObject.cpp:
(WebCore::AccessibilityObject::stringForRange const):

Canonical link: https://commits.webkit.org/276843@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications