[webkit-changes] [WebKit/WebKit] 0d17a4: REGRESSION (276119 at main): [ macOS iOS ] http/tests...

[Sihui]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 0d17a4e9d153af2f1937cbc4539579fd1301deb8
      https://github.com/WebKit/WebKit/commit/0d17a4e9d153af2f1937cbc4539579fd1301deb8
  Author: Sihui Liu <sihui_liu at apple.com>
  Date:   2024-03-29 (Fri, 29 Mar 2024)

  Changed paths:
    M LayoutTests/http/tests/navigation/page-cache-getUserMedia-pending-promise.html

  Log Message:
  -----------
  REGRESSION (276119 at main): [ macOS iOS ] http/tests/navigation/page-cache-getUserMedia-pending-promise.html is a flaky timeout
https://bugs.webkit.org/show_bug.cgi?id=271063
rdar://124698382

Reviewed by Chris Dumez.

276618 at main made the test go from consistent timeout to flakily failure. The test fails because user media permission
request is granted, and the test expects it to be denied. The test expects the request result to be denied because our
current implementation invalidates (denies) pending permission request when main Document changes for the page. However,
there is a race between request handled by UI process and UI process gets notification about Document change. If the
request is handled before notification, UI process will grant it because the test sets the permission to allowed with
setUserMediaPermission.

To avoid the flakiness, this patch makes the test to set the permission to false. By doing this, the permission request
result will be rejected consistently.

* LayoutTests/http/tests/navigation/page-cache-getUserMedia-pending-promise.html:

Canonical link: https://commits.webkit.org/276836@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications