[webkit-changes] [WebKit/WebKit] 641e3a: Prevent compile options from being added to MASM w...

Don Olmstead noreply at github.com
Fri Mar 29 10:38:49 PDT 2024


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 641e3aa79194b53c4ea7d52113bca8c68713a255
      https://github.com/WebKit/WebKit/commit/641e3aa79194b53c4ea7d52113bca8c68713a255
  Author: Don Olmstead <don.olmstead at sony.com>
  Date:   2024-03-29 (Fri, 29 Mar 2024)

  Changed paths:
    M Source/cmake/OptionsMSVC.cmake

  Log Message:
  -----------
  Prevent compile options from being added to MASM within VS
https://bugs.webkit.org/show_bug.cgi?id=271861

Reviewed by Fujii Hironori.

When building within Visual Studio the CMake generator ends up adding values
from `add_compile_options` to the MASM compilation. This breaks compilation of
assembly files. Work around this by adding a CMake function that uses a
generator expression based on the language.

* Source/cmake/OptionsMSVC.cmake:

Canonical link: https://commits.webkit.org/276831@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications


More information about the webkit-changes mailing list