[webkit-changes] [WebKit/WebKit] baf506: Make bindRemoteAccessibilityFrames declaration con...

Don Olmstead noreply at github.com
Thu Mar 28 16:09:10 PDT 2024


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: baf5067a2bd642e023ffee731b37090d974715e0
      https://github.com/WebKit/WebKit/commit/baf5067a2bd642e023ffee731b37090d974715e0
  Author: Don Olmstead <don.olmstead at sony.com>
  Date:   2024-03-28 (Thu, 28 Mar 2024)

  Changed paths:
    M Source/WebCore/page/RemoteFrame.cpp
    M Source/WebCore/page/RemoteFrameClient.h
    M Source/WebKit/UIProcess/WebPageProxy.cpp
    M Source/WebKit/WebProcess/WebCoreSupport/WebRemoteFrameClient.cpp

  Log Message:
  -----------
  Make bindRemoteAccessibilityFrames declaration consistent
https://bugs.webkit.org/show_bug.cgi?id=271833

Reviewed by Chris Dumez.

In 274955 at main the method `bindRemoteAccessibilityFrames` was added to
`RemoteFrameClient`. When overridden in `WebRemoteFrameClient` the
signature didn't match which triggered a warning in MSVC, C4373, due to
`const` qualifiers. This patch just makes the `std::span<const uint8_t>`
parameters consistent across the previous patch.

* Source/WebCore/page/RemoteFrame.cpp:
* Source/WebCore/page/RemoteFrameClient.h:
* Source/WebKit/UIProcess/WebPageProxy.cpp:
* Source/WebKit/WebProcess/WebCoreSupport/WebRemoteFrameClient.cpp:

Canonical link: https://commits.webkit.org/276809@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications


More information about the webkit-changes mailing list