[webkit-changes] [WebKit/WebKit] 188bb9: AX: Cells within a grid should compute Accessibili...

[Tyler Wilcock]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 188bb938577a3d46b464955774828eacc975d17c
      https://github.com/WebKit/WebKit/commit/188bb938577a3d46b464955774828eacc975d17c
  Author: Tyler Wilcock <tyler_w at apple.com>
  Date:   2024-03-28 (Thu, 28 Mar 2024)

  Changed paths:
    A LayoutTests/accessibility/aria-table-selection-support-expected.txt
    A LayoutTests/accessibility/aria-table-selection-support.html
    M LayoutTests/imported/w3c/web-platform-tests/css/css-display/accessibility/display-contents-role-and-label-expected.txt
    M LayoutTests/platform/glib/TestExpectations
    M LayoutTests/platform/glib/imported/w3c/web-platform-tests/css/css-display/accessibility/display-contents-role-and-label-expected.txt
    M Source/WebCore/Sources.txt
    M Source/WebCore/WebCore.xcodeproj/project.pbxproj
    M Source/WebCore/accessibility/AXCoreObject.h
    M Source/WebCore/accessibility/AXObjectCache.cpp
    M Source/WebCore/accessibility/AXObjectCache.h
    R Source/WebCore/accessibility/AccessibilityARIAGrid.cpp
    R Source/WebCore/accessibility/AccessibilityARIAGrid.h
    A Source/WebCore/accessibility/AccessibilityARIATable.cpp
    A Source/WebCore/accessibility/AccessibilityARIATable.h
    M Source/WebCore/accessibility/AccessibilityObject.h
    M Source/WebCore/accessibility/AccessibilityTable.cpp
    M Source/WebCore/accessibility/AccessibilityTable.h
    M Source/WebCore/accessibility/AccessibilityTableCell.cpp
    M Source/WebCore/accessibility/isolatedtree/AXIsolatedObject.h

  Log Message:
  -----------
  AX: Cells within a grid should compute AccessibilityRole::GridCell rather than AccessibilityRole::Cell
https://bugs.webkit.org/show_bug.cgi?id=271803
rdar://problem/125512886

Reviewed by Chris Fleizach.

AccessibilityTableCell::determineAccessibilityRole() now checks whether
it is within a grid or a table, computing AccessibilityRole::GridCell or
AccessibilityRole::Cell respectively.

This patch also fixes a bug where we supported AXSelectedRows and
aria-multiselectable for role="table" elements, despite the spec stating
we should not do this. A new test, aria-table-selection-support.html, is
added to verify the correct behavior.

The other significant change in this patch is the renaming of
AccessibilityARIAGrid to AccessibilityARIATable. The former name was not
accurate, as we also created AccessibilityARIAGrid for role="table"
elements.

This change allows us to pass 2 more WPT subtests.

* LayoutTests/accessibility/aria-table-selection-support-expected.txt: Added.
* LayoutTests/accessibility/aria-table-selection-support.html: Added.
* LayoutTests/imported/w3c/web-platform-tests/css/css-display/accessibility/display-contents-role-and-label-expected.txt:
* LayoutTests/platform/glib/TestExpectations:
* LayoutTests/platform/glib/imported/w3c/web-platform-tests/css/css-display/accessibility/display-contents-role-and-label-expected.txt:
* Source/WebCore/Sources.txt:
* Source/WebCore/WebCore.xcodeproj/project.pbxproj:
* Source/WebCore/accessibility/AXCoreObject.h:
* Source/WebCore/accessibility/AXObjectCache.cpp:
(WebCore::nodeHasTableRole):
(WebCore::isAccessibilityARIATable):
(WebCore::AXObjectCache::createObjectFromRenderer):
(WebCore::createFromNode):
(WebCore::nodeHasGridRole): Deleted.
(WebCore::isAccessibilityARIAGrid): Deleted.
* Source/WebCore/accessibility/AXObjectCache.h:
* Source/WebCore/accessibility/AccessibilityARIATable.cpp: Renamed from Source/WebCore/accessibility/AccessibilityARIAGrid.cpp.
(WebCore::AccessibilityARIATable::AccessibilityARIATable):
(WebCore::AccessibilityARIATable::create):
(WebCore::AccessibilityARIATable::isMultiSelectable const):
* Source/WebCore/accessibility/AccessibilityARIATable.h: Renamed from Source/WebCore/accessibility/AccessibilityARIAGrid.h.
* Source/WebCore/accessibility/AccessibilityObject.h:
(WebCore::AccessibilityObject::isAccessibilityTableColumnInstance const):
* Source/WebCore/accessibility/AccessibilityTable.cpp:
(WebCore::AccessibilityTable::hasGridAriaRole const):
* Source/WebCore/accessibility/AccessibilityTable.h:
* Source/WebCore/accessibility/AccessibilityTableCell.cpp:
(WebCore::AccessibilityTableCell::computeAccessibilityIsIgnored const):
(WebCore::AccessibilityTableCell::determineAccessibilityRole):
* Source/WebCore/accessibility/isolatedtree/AXIsolatedObject.h:

Canonical link: https://commits.webkit.org/276800@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications