[webkit-changes] [WebKit/WebKit] ab28ad: shorthand value for CSS gap is not kept as-is in s...

Karl Dubost noreply at github.com
Thu Mar 28 12:24:19 PDT 2024


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: ab28ade5ffd5e80451a6a8fc8b0cff43c722ad64
      https://github.com/WebKit/WebKit/commit/ab28ade5ffd5e80451a6a8fc8b0cff43c722ad64
  Author: Karl Dubost <karlcow at apple.com>
  Date:   2024-03-28 (Thu, 28 Mar 2024)

  Changed paths:
    M LayoutTests/imported/w3c/web-platform-tests/css/css-align/gaps/gap-animation-001-expected.txt
    M LayoutTests/imported/w3c/web-platform-tests/css/css-align/gaps/gap-animation-002-expected.txt
    M LayoutTests/imported/w3c/web-platform-tests/css/css-align/gaps/gap-animation-003-expected.txt
    M LayoutTests/imported/w3c/web-platform-tests/css/css-align/gaps/gap-parsing-002-expected.txt
    M LayoutTests/imported/w3c/web-platform-tests/css/css-align/parsing/gap-computed-expected.txt
    M Source/WebCore/css/CSSComputedStyleDeclaration.cpp
    M Source/WebCore/css/StyleProperties.cpp

  Log Message:
  -----------
  shorthand value for CSS gap is not kept as-is in serialized and computed values.
https://bugs.webkit.org/show_bug.cgi?id=271627
rdar://125335787

Reviewed by Tim Nguyen.

When the shorthand CSS property gap is used, the cssText and computed
declaration can stay in the short form when the values for column and
row are identical.

* LayoutTests/imported/w3c/web-platform-tests/css/css-align/gaps/gap-animation-001-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/css/css-align/gaps/gap-animation-002-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/css/css-align/gaps/gap-animation-003-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/css/css-align/gaps/gap-parsing-002-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/css/css-align/parsing/gap-computed-expected.txt:
* Source/WebCore/css/CSSComputedStyleDeclaration.cpp:
(WebCore::CSSComputedStyleDeclaration::getPropertyValue const):
* Source/WebCore/css/StyleProperties.cpp:
(WebCore::canUseShorthandForLonghand):

Canonical link: https://commits.webkit.org/276794@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications


More information about the webkit-changes mailing list