[webkit-changes] [WebKit/WebKit] bbfd3d: [visionOS] Captions do not render in Linear Media ...

[aestes]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: bbfd3d9efcbb9c24abb655b8759ee700ef5d5f34
      https://github.com/WebKit/WebKit/commit/bbfd3d9efcbb9c24abb655b8759ee700ef5d5f34
  Author: Andy Estes <aestes at apple.com>
  Date:   2024-03-27 (Wed, 27 Mar 2024)

  Changed paths:
    M Source/WebCore/platform/cocoa/VideoFullscreenCaptions.h
    M Source/WebCore/platform/cocoa/VideoFullscreenCaptions.mm
    M Source/WebCore/platform/graphics/cocoa/NullVideoPresentationInterface.h
    M Source/WebCore/platform/ios/VideoPresentationInterfaceIOS.h
    M Source/WebCore/platform/mac/VideoPresentationInterfaceMac.h
    M Source/WebKit/Platform/ios/VideoPresentationInterfaceLMK.h
    M Source/WebKit/Platform/ios/VideoPresentationInterfaceLMK.mm

  Log Message:
  -----------
  [visionOS] Captions do not render in Linear Media Player
https://bugs.webkit.org/show_bug.cgi?id=271797
rdar://124223292

Reviewed by Jer Noble.

Re-enabled captions by setting VideoPresentationInterfaceLMK::captionsLayer() as
WKSLinearMediaPlayer's captionLayer. Fixed the bug that caused us to previously disable captions by
ensuring the captions layer is unparented and does not have an explicit zPosition. LinearMediaKit
expects to insert the caption layer into its hierarchy and manage its z-order.

* Source/WebCore/platform/cocoa/VideoFullscreenCaptions.h:
* Source/WebCore/platform/cocoa/VideoFullscreenCaptions.mm:
(WebCore::VideoFullscreenCaptions::setupCaptionsLayer):
* Source/WebCore/platform/graphics/cocoa/NullVideoPresentationInterface.h:
* Source/WebCore/platform/ios/VideoPresentationInterfaceIOS.h:
* Source/WebCore/platform/mac/VideoPresentationInterfaceMac.h:
* Source/WebKit/Platform/ios/VideoPresentationInterfaceLMK.h:
* Source/WebKit/Platform/ios/VideoPresentationInterfaceLMK.mm:
(WebKit::VideoPresentationInterfaceLMK::setupPlayerViewController):
(WebKit::VideoPresentationInterfaceLMK::setupCaptionsLayer):

Canonical link: https://commits.webkit.org/276771@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications