[webkit-changes] [WebKit/WebKit] 1122d9: AX: [WKAccessibilityWebPageObject accessibilityAtt...

[AndresGonzalezApple]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 1122d9ab29ce37e20759f70915a269c3e2d27982
      https://github.com/WebKit/WebKit/commit/1122d9ab29ce37e20759f70915a269c3e2d27982
  Author: Andres Gonzalez <andresg_22 at apple.com>
  Date:   2024-03-26 (Tue, 26 Mar 2024)

  Changed paths:
    M Source/WebKit/WebProcess/WebPage/mac/WKAccessibilityWebPageObjectMac.mm

  Log Message:
  -----------
  AX: [WKAccessibilityWebPageObject accessibilityAttributeValue:] should retrieve several properties from the main thread.
https://bugs.webkit.org/show_bug.cgi?id=271675
<rdar://problem/125374335>

Reviewed by Tyler Wilcock.

Several of the AX API attributes including NSAccessibilityWindowAttribute and NSAccessibilityPrimaryScreenHeightAttribute need to be retrieved from the main thread. Among other problems, this may be the cause of intermittent crashes we observe in accessibility/primary-screen-height.html. This patch changes this method to execute on the AX thread only those properties that are safe off the main thread, and to dispatch to the main thread the rest.

* Source/WebKit/WebProcess/WebPage/mac/WKAccessibilityWebPageObjectMac.mm:
(-[WKAccessibilityWebPageObject accessibilityAttributeValue:]):

Canonical link: https://commits.webkit.org/276686@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications