[webkit-changes] [WebKit/WebKit] 779251: Complete transition to std::span in CryptoDigest-r...

Brent Fulgham noreply at github.com
Mon Mar 25 21:20:06 PDT 2024 

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 779251105768188876c269d293475f2a65f2152c
      https://github.com/WebKit/WebKit/commit/779251105768188876c269d293475f2a65f2152c
  Author: Brent Fulgham <bfulgham at apple.com>
  Date:   2024-03-25 (Mon, 25 Mar 2024)

  Changed paths:
    M Source/JavaScriptCore/API/JSScript.mm
    M Source/JavaScriptCore/bytecode/CodeBlockHash.cpp
    M Source/JavaScriptCore/inspector/remote/glib/RemoteInspectorUtils.cpp
    M Source/JavaScriptCore/runtime/CachedBytecode.h
    M Source/WTF/wtf/SHA1.h
    M Source/WTF/wtf/persistence/PersistentEncoder.cpp
    M Source/WTF/wtf/persistence/PersistentEncoder.h
    M Source/WebCore/Modules/webauthn/WebAuthenticationUtils.cpp
    M Source/WebCore/Modules/websockets/WebSocketHandshake.cpp
    M Source/WebCore/PAL/pal/crypto/CryptoDigest.h
    M Source/WebCore/PAL/pal/crypto/commoncrypto/CryptoDigestCommonCrypto.mm
    M Source/WebCore/PAL/pal/crypto/gcrypt/CryptoDigestGCrypt.cpp
    M Source/WebCore/PAL/pal/crypto/openssl/CryptoDigestOpenSSL.cpp
    M Source/WebCore/PAL/pal/crypto/win/CryptoDigestWin.cpp
    M Source/WebCore/crypto/gcrypt/CryptoAlgorithmECDSAGCrypt.cpp
    M Source/WebCore/crypto/gcrypt/CryptoAlgorithmRSASSA_PKCS1_v1_5GCrypt.cpp
    M Source/WebCore/crypto/gcrypt/CryptoAlgorithmRSA_PSSGCrypt.cpp
    M Source/WebCore/css/FontFace.cpp
    M Source/WebCore/dom/Node.cpp
    M Source/WebCore/inspector/DOMPatchSupport.cpp
    M Source/WebCore/loader/ResourceCryptographicDigest.cpp
    M Source/WebCore/loader/ResourceCryptographicDigest.h
    M Source/WebCore/loader/cache/TrustedFonts.cpp
    M Source/WebCore/loader/cache/TrustedFonts.h
    M Source/WebCore/page/csp/ContentSecurityPolicy.cpp
    M Source/WebCore/platform/mediastream/RealtimeMediaSourceCenter.cpp
    M Source/WebCore/platform/network/soup/SoupNetworkSession.cpp
    M Source/WebCore/storage/StorageUtilities.cpp
    M Source/WebCore/workers/service/server/SWScriptStorage.cpp
    M Source/WebKit/NetworkProcess/cache/NetworkCacheData.cpp
    M Source/WebKit/NetworkProcess/cache/NetworkCacheKey.cpp
    M Source/WebKit/NetworkProcess/storage/CacheStorageDiskStore.cpp
    M Source/WebKit/NetworkProcess/storage/NetworkStorageManager.cpp
    M Source/WebKit/UIProcess/API/Cocoa/_WKWebAuthenticationPanel.mm
    M Source/WebKit/UIProcess/WebAuthentication/Cocoa/LocalAuthenticator.mm
    M Source/WebKit/UIProcess/WebAuthentication/Virtual/VirtualAuthenticatorUtils.mm
    M Tools/DumpRenderTree/cg/PixelDumpSupportCG.cpp
    M Tools/TestWebKitAPI/Tests/WTF/BloomFilter.cpp
    M Tools/TestWebKitAPI/Tests/WebCore/CryptoDigest.cpp
    M Tools/TestWebKitAPI/cocoa/HTTPServer.mm
    M Tools/WebKitTestRunner/cairo/TestInvocationCairo.cpp
    M Tools/WebKitTestRunner/cg/TestInvocationCG.cpp
    M Tools/WebKitTestRunner/skia/TestInvocationSkia.cpp

  Log Message:
  -----------
  Complete transition to std::span in CryptoDigest-related code
https://bugs.webkit.org/show_bug.cgi?id=271488
<rdar://problem/125256518>

Reviewed by Chris Dumez and Sihui Liu.

Following the changes in Bug 249414 and Bug 271383, complete the work of
moving to std::span in CryptoDigest-related code.

* Source/JavaScriptCore/API/JSScript.mm:
(-[JSScript readCache]):
(-[JSScript writeCache:]):
* Source/JavaScriptCore/bytecode/CodeBlockHash.cpp:
(JSC::CodeBlockHash::CodeBlockHash):
* Source/JavaScriptCore/inspector/remote/glib/RemoteInspectorUtils.cpp:
(Inspector::backendCommandsHash):
* Source/JavaScriptCore/runtime/CachedBytecode.h:
(JSC::CachedBytecode::span const):
* Source/WTF/wtf/SHA1.h:
* Source/WTF/wtf/persistence/PersistentEncoder.cpp:
(WTF::Persistence::Encoder::updateChecksumForData):
* Source/WTF/wtf/persistence/PersistentEncoder.h:
(WTF::Persistence::Encoder::updateChecksumForNumber):
* Source/WebCore/Modules/webauthn/WebAuthenticationUtils.cpp:
(WebCore::buildClientDataJsonHash):
* Source/WebCore/Modules/websockets/WebSocketHandshake.cpp:
(WebCore::WebSocketHandshake::getExpectedWebSocketAccept):
* Source/WebCore/PAL/pal/crypto/CryptoDigest.h:
(PAL::CryptoDigest::addBytes): Deleted.
* Source/WebCore/PAL/pal/crypto/commoncrypto/CryptoDigestCommonCrypto.mm:
(PAL::CryptoDigest::addBytes):
* Source/WebCore/PAL/pal/crypto/gcrypt/CryptoDigestGCrypt.cpp:
(PAL::CryptoDigest::addBytes):
* Source/WebCore/PAL/pal/crypto/openssl/CryptoDigestOpenSSL.cpp:
(PAL::CryptoDigest::addBytes):
* Source/WebCore/PAL/pal/crypto/win/CryptoDigestWin.cpp:
(PAL::CryptoDigest::addBytes):
* Source/WebCore/css/FontFace.cpp:
(WebCore::FontFace::create):
* Source/WebCore/crypto/gcrypt/CryptoAlgorithmECDSAGCrypt.cpp:
(WebCore::gcryptSign):
(WebCore::gcryptVerify):
* Source/WebCore/crypto/gcrypt/CryptoAlgorithmRSASSA_PKCS1_v1_5GCrypt.cpp:
(WebCore::gcryptSign):
(WebCore::gcryptVerify):
* Source/WebCore/crypto/gcrypt/CryptoAlgorithmRSA_PSSGCrypt.cpp:
(WebCore::gcryptSign):
(WebCore::gcryptVerify):
* Source/WebCore/dom/Node.cpp:
(WebCore::hashPointer):
* Source/WebCore/inspector/DOMPatchSupport.cpp:
(WebCore::DOMPatchSupport::createDigest):
* Source/WebCore/loader/ResourceCryptographicDigest.cpp:
(WebCore::cryptographicDigestForBytes):
* Source/WebCore/loader/ResourceCryptographicDigest.h:
* Source/WebCore/loader/cache/TrustedFonts.cpp:
(WebCore::hashForFontData):
(WebCore::fontBinaryParsingPolicy):
* Source/WebCore/loader/cache/TrustedFonts.h:
* Source/WebCore/page/csp/ContentSecurityPolicy.cpp:
(WebCore::generateHashesForContent):
* Source/WebCore/platform/mediastream/RealtimeMediaSourceCenter.cpp:
(WebCore::addStringToSHA1):
* Source/WebCore/platform/network/soup/SoupNetworkSession.cpp:
(WebCore::HostTLSCertificateSet::computeCertificateHash):
* Source/WebCore/storage/StorageUtilities.cpp:
(WebCore::StorageUtilities::encodeSecurityOriginForFileName):
* Source/WebCore/workers/service/server/SWScriptStorage.cpp:
(WebCore::SWScriptStorage::sha2Hash const):
* Source/WebKit/NetworkProcess/cache/NetworkCacheData.cpp:
(WebKit::NetworkCache::computeSHA1):
* Source/WebKit/NetworkProcess/cache/NetworkCacheKey.cpp:
(WebKit::NetworkCache::hashString):
(WebKit::NetworkCache::Key::computeHash const):
(WebKit::NetworkCache::Key::partitionToPartitionHash):
* Source/WebKit/NetworkProcess/storage/CacheStorageDiskStore.cpp:
(WebKit::computeSHA1):
* Source/WebKit/NetworkProcess/storage/NetworkStorageManager.cpp:
(WebKit::encode):
* Source/WebKit/UIProcess/API/Cocoa/_WKWebAuthenticationPanel.mm:
(produceClientDataJsonHash):
(+[_WKWebAuthenticationPanel importLocalAuthenticatorWithAccessGroup:credential:error:]):
* Source/WebKit/UIProcess/WebAuthentication/Cocoa/LocalAuthenticator.mm:
(WebKit::LocalAuthenticator::continueMakeCredentialAfterUserVerification):
* Source/WebKit/UIProcess/WebAuthentication/Virtual/VirtualAuthenticatorUtils.mm:
(WebKit::credentialIdAndCosePubKeyForPrivateKey):
* Tools/DumpRenderTree/cg/PixelDumpSupportCG.cpp:
(computeSHA1HashStringForBitmapContext):
* Tools/TestWebKitAPI/Tests/WTF/BloomFilter.cpp:
(TestWebKitAPI::generateRandomDigests):
* Tools/TestWebKitAPI/Tests/WebCore/CryptoDigest.cpp:
(TestWebKitAPI::expect):
* Tools/TestWebKitAPI/cocoa/HTTPServer.mm:
(TestWebKitAPI::Connection::webSocketHandshake):
* Tools/WebKitTestRunner/cairo/TestInvocationCairo.cpp:
(WTR::computeSHA1HashStringForCairoSurface):
* Tools/WebKitTestRunner/skia/TestInvocationSkia.cpp:
(WTR::computeSHA1HashStringForPixmap):

* Tools/WebKitTestRunner/cg/TestInvocationCG.cpp:
(WTR::computeSHA1HashStringForContext):

Canonical link: https://commits.webkit.org/276673@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications

More information about the webkit-changes mailing list