[webkit-changes] [WebKit/WebKit] c52499: AX: Assert crash in [WebAccessibilityObjectWrapper...

[AndresGonzalezApple]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: c5249991fba8d30b23b5c8449efd3f0686728d01
      https://github.com/WebKit/WebKit/commit/c5249991fba8d30b23b5c8449efd3f0686728d01
  Author: Andres Gonzalez <andresg_22 at apple.com>
  Date:   2024-03-25 (Mon, 25 Mar 2024)

  Changed paths:
    M Source/WebCore/accessibility/AXCoreObject.h
    M Source/WebCore/accessibility/AccessibilityObject.h
    M Source/WebCore/accessibility/isolatedtree/AXIsolatedObject.h
    M Source/WebCore/accessibility/isolatedtree/AXIsolatedTree.h
    M Source/WebCore/accessibility/mac/WebAccessibilityObjectWrapperMac.mm

  Log Message:
  -----------
  AX: Assert crash in [WebAccessibilityObjectWrapper accessibilityPresenterProcessIdentifier].
https://bugs.webkit.org/show_bug.cgi?id=271652
<rdar://problem/125357232>

Reviewed by Chris Fleizach.

Partial revert of https://bugs.webkit.org/show_bug.cgi?id=270866 (276073 at main).
We are hitting the following assert on launch if VoiceOver is running:

int presentingApplicationPID()
{
    const auto& pid = presentingApplicationPIDOverride();
    ASSERT(!pid || RunLoop::isMain());
...

This patch reverts getting the process ID in the wrapper from the cached value in the AXIsolatedTree as it was before the above change.

* Source/WebCore/accessibility/AXCoreObject.h:
* Source/WebCore/accessibility/AccessibilityObject.h:
* Source/WebCore/accessibility/isolatedtree/AXIsolatedObject.h:
* Source/WebCore/accessibility/isolatedtree/AXIsolatedTree.h:
(WebCore::AXIsolatedTree::treeID const):
(WebCore::AXIsolatedTree::processID const):
* Source/WebCore/accessibility/mac/WebAccessibilityObjectWrapperMac.mm:
(-[WebAccessibilityObjectWrapper accessibilityPresenterProcessIdentifier]):

Canonical link: https://commits.webkit.org/276668@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications