[webkit-changes] [WebKit/WebKit] 508e18: Fix "use-after-free" warning in WebCore/page/Navig...

[Patrick]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 508e1805310e8f0136a08d4449bc3b23720a6ecc
      https://github.com/WebKit/WebKit/commit/508e1805310e8f0136a08d4449bc3b23720a6ecc
  Author: Patrick Griffis <pgriffis at igalia.com>
  Date:   2024-03-25 (Mon, 25 Mar 2024)

  Changed paths:
    M Source/WebCore/page/NavigateEvent.cpp
    M Source/WebCore/page/NavigateEvent.h
    M Source/WebCore/page/Navigation.cpp

  Log Message:
  -----------
  Fix "use-after-free" warning in WebCore/page/Navigation.cpp with GCC 12
https://bugs.webkit.org/show_bug.cgi?id=271648

Reviewed by Michael Catanzaro.

GCC hits a bug with copying this RefPtr by value for some reason.

This should never have been passed by value anyway and since it
doesn't take ownership should have been passed by a raw pointer.

* Source/WebCore/page/NavigateEvent.cpp:
(WebCore::NavigateEvent::NavigateEvent):
(WebCore::NavigateEvent::create):
* Source/WebCore/page/NavigateEvent.h:
* Source/WebCore/page/Navigation.cpp:
(WebCore::Navigation::innerDispatchNavigateEvent):

Canonical link: https://commits.webkit.org/276662@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications