[webkit-changes] [WebKit/WebKit] d87f5d: AX: Mac combo boxes should expose aria-activedesce...

[Commit Queue]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: d87f5d6705184810976f06f36392729a3e964b39
      https://github.com/WebKit/WebKit/commit/d87f5d6705184810976f06f36392729a3e964b39
  Author: Dominic Mazzoni <dm_mazzoni at apple.com>
  Date:   2024-03-25 (Mon, 25 Mar 2024)

  Changed paths:
    A LayoutTests/accessibility/mac/aria-combobox-activedescendant-expected.txt
    A LayoutTests/accessibility/mac/aria-combobox-activedescendant.html
    M Source/WebCore/accessibility/AXCoreObject.cpp
    M Source/WebCore/accessibility/AccessibilityObject.cpp
    M Source/WebCore/accessibility/mac/WebAccessibilityObjectWrapperMac.mm

  Log Message:
  -----------
  AX: Mac combo boxes should expose aria-activedescendant as AXSelectedChildren
https://bugs.webkit.org/show_bug.cgi?id=271287
rdar://problem/125050867

Reviewed by Andres Gonzalez.

This is necessary, but probably not sufficient, to support
https://bugs.webkit.org/show_bug.cgi?id=231724 (AX: VoiceOver doesn't
announce aria-activedescendant value for select-only combobox
specification). There are other bugs preventing VoiceOver from working
but exposing the active descendant is pretty fundamental so I'd like
to get that in first.

Part of the bug is that an element can be both a combo box and a text
field, so the supported attribute logic needed to be updated to take
that into account.

* LayoutTests/accessibility/mac/aria-combobox-activedescendant-expected.txt: Added.
* LayoutTests/accessibility/mac/aria-combobox-activedescendant.html: Added.
* Source/WebCore/accessibility/AXCoreObject.cpp:
(WebCore::AXCoreObject::canHaveSelectedChildren const):
* Source/WebCore/accessibility/AccessibilityObject.cpp:
(WebCore::AccessibilityObject::selectedChildren):
* Source/WebCore/accessibility/mac/WebAccessibilityObjectWrapperMac.mm:
(-[WebAccessibilityObjectWrapper ALLOW_DEPRECATED_IMPLEMENTATIONS_END]):

Canonical link: https://commits.webkit.org/276627@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications