[webkit-changes] [WebKit/WebKit] d196c0: [IFC][Cleanup] Rename InlineDamage::start to Inlin...

[Alan Baradlay]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: d196c00cc9dac4580860401ee5944e9a872d92cd
      https://github.com/WebKit/WebKit/commit/d196c00cc9dac4580860401ee5944e9a872d92cd
  Author: Alan Baradlay <zalan at apple.com>
  Date:   2024-03-24 (Sun, 24 Mar 2024)

  Changed paths:
    M Source/WebCore/layout/formattingContexts/inline/InlineFormattingContext.cpp
    M Source/WebCore/layout/formattingContexts/inline/invalidation/InlineDamage.h
    M Source/WebCore/layout/formattingContexts/inline/invalidation/InlineInvalidation.cpp
    M Source/WebCore/layout/integration/LayoutIntegrationCoverage.cpp
    M Source/WebCore/layout/integration/inline/LayoutIntegrationInlineContentBuilder.cpp
    M Source/WebCore/layout/integration/inline/LayoutIntegrationLineLayout.cpp

  Log Message:
  -----------
  [IFC][Cleanup] Rename InlineDamage::start to InlineDamage::layoutStartPosition
https://bugs.webkit.org/show_bug.cgi?id=271532

Reviewed by Antti Koivisto.

InlineDamage::start assumes the starting point of the damage, while in most cases start()
points to a line before the damage point. It defines the position where subsequent line layout should start from.

* Source/WebCore/layout/formattingContexts/inline/InlineFormattingContext.cpp:
(WebCore::Layout::partialRangeForDamage):
(WebCore::Layout::InlineFormattingContext::layout):
(WebCore::Layout::mayExitFromPartialLayout):
(WebCore::Layout::InlineFormattingContext::lineLayout):
(WebCore::Layout::InlineFormattingContext::rebuildInlineItemListIfNeeded):
* Source/WebCore/layout/formattingContexts/inline/invalidation/InlineDamage.h:
(WebCore::Layout::InlineDamage::layoutStartPosition const):
(WebCore::Layout::InlineDamage::setLayoutStartPosition):
(WebCore::Layout::InlineDamage::trailingContentForLine const):
(WebCore::Layout::InlineDamage::reset):
(WebCore::Layout::InlineDamage::start const): Deleted.
(WebCore::Layout::InlineDamage::setDamagedPosition): Deleted.
* Source/WebCore/layout/formattingContexts/inline/invalidation/InlineInvalidation.cpp:
(WebCore::Layout::InlineInvalidation::updateInlineDamage):
* Source/WebCore/layout/integration/LayoutIntegrationCoverage.cpp:
(WebCore::LayoutIntegration::shouldInvalidateLineLayoutPathAfterChangeFor):
* Source/WebCore/layout/integration/inline/LayoutIntegrationInlineContentBuilder.cpp:
(WebCore::LayoutIntegration::InlineContentBuilder::build const):
* Source/WebCore/layout/integration/inline/LayoutIntegrationLineLayout.cpp:
(WebCore::LayoutIntegration::LineLayout::layout):

Canonical link: https://commits.webkit.org/276615@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications