[webkit-changes] [WebKit/WebKit] ad8d3e: ASSERTION FAILED: watchpoints (./runtime/ScopedArg...

[Michael Saboff]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: ad8d3e19e21357cd9d1959b86e92dba341d0bcbe
      https://github.com/WebKit/WebKit/commit/ad8d3e19e21357cd9d1959b86e92dba341d0bcbe
  Author: Michael Saboff <msaboff at apple.com>
  Date:   2024-03-23 (Sat, 23 Mar 2024)

  Changed paths:
    M JSTests/stress/arrow-function-captured-arguments-aliased.js
    M Source/JavaScriptCore/runtime/ScopedArgumentsTable.cpp

  Log Message:
  -----------
  ASSERTION FAILED: watchpoints (./runtime/ScopedArgumentsTable.cpp(130))
rdar://121446658
https://bugs.webkit.org/show_bug.cgi?id=267946

Reviewed by Alexey Shvayka.

Insatead of using an ASSERT that we have a valid WatchpointSet in ScopedArgumentsTable::trySetWatchpointSet(), we can just
exit early if the passed in WatchpointSet is null.  This can happen if the JIT is not enabled.

Updated the test to run both with and wothout the JIT.

* JSTests/stress/arrow-function-captured-arguments-aliased.js:
* Source/JavaScriptCore/runtime/ScopedArgumentsTable.cpp:
(JSC::ScopedArgumentsTable::trySetWatchpointSet):

Originally-landed-as: 272448.339 at safari-7618-branch (66df5c618c1c). rdar://124555300
Canonical link: https://commits.webkit.org/276598@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications