[webkit-changes] [WebKit/WebKit] 1d616d: AX: AXObjectCache::gForceInitialFrameCaching and g...

[AndresGonzalezApple]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 1d616d98c57f644cadc134aff8365435f7537edf
      https://github.com/WebKit/WebKit/commit/1d616d98c57f644cadc134aff8365435f7537edf
  Author: Andres Gonzalez <andresg_22 at apple.com>
  Date:   2024-03-22 (Fri, 22 Mar 2024)

  Changed paths:
    M Source/WebCore/accessibility/AXObjectCache.cpp
    M Source/WebCore/accessibility/AXObjectCache.h

  Log Message:
  -----------
  AX: AXObjectCache::gForceInitialFrameCaching and gAccessibilityThreadTextApisEnabled are not thread safe.
https://bugs.webkit.org/show_bug.cgi?id=271436
<rdar://problem/125208308>

Reviewed by Chris Fleizach.

These two static member variables are accessed on and off the main thread. This patch changes the type to std::atomic<bool>s. The other three AXObjectCache static member variables are main thread only, and asserts were added to ensure that.

* Source/WebCore/accessibility/AXObjectCache.cpp:
(WebCore::AXObjectCache::accessibilityEnabled):
(WebCore::AXObjectCache::disableAccessibility):
(WebCore::AXObjectCache::forceDeferredSpellChecking):
(WebCore::AXObjectCache::setForceDeferredSpellChecking):
(WebCore::AXObjectCache::accessibilityEnhancedUserInterfaceEnabled):
(WebCore::AXObjectCache::setEnhancedUserInterfaceAccessibility):
* Source/WebCore/accessibility/AXObjectCache.h:

Canonical link: https://commits.webkit.org/276576@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications