[webkit-changes] [WebKit/WebKit] 9a7846: GPUConnectionToWebProcess::setTCCIdentity need to ...

[youennf]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 9a7846e7b496cc9440733c54eb8bdf3bec33cf5d
      https://github.com/WebKit/WebKit/commit/9a7846e7b496cc9440733c54eb8bdf3bec33cf5d
  Author: Youenn Fablet <youenn at apple.com>
  Date:   2024-03-22 (Fri, 22 Mar 2024)

  Changed paths:
    M Source/WebKit/GPUProcess/cocoa/GPUConnectionToWebProcessCocoa.mm

  Log Message:
  -----------
  GPUConnectionToWebProcess::setTCCIdentity need to check that it has a bundle identifier before calling tcc_identity_create
https://bugs.webkit.org/show_bug.cgi?id=271459
rdar://122836442

Reviewed by Eric Carlson.

As can be seen from crash logs, we are sometimes calling tcc_identity_create with a nullptr identifier.
This identifier is coming from the bundle proxy created by [LSBundleProxy bundleProxyWithAuditToken:error:].
This function can probably return nil without an error, or the returned bundle proxy has a nullptr identifier.
We add an if check that covers both cases and add release logging to know the exact issue.

* Source/WebKit/GPUProcess/cocoa/GPUConnectionToWebProcessCocoa.mm:
(WebKit::GPUConnectionToWebProcess::setTCCIdentity):

Canonical link: https://commits.webkit.org/276549@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications