[webkit-changes] [WebKit/WebKit] 353c94: [@starting-style] Contents of popover is not rende...

[Antti Koivisto]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 353c94ffa3f78de045388574a4cae299d124998e
      https://github.com/WebKit/WebKit/commit/353c94ffa3f78de045388574a4cae299d124998e
  Author: Antti Koivisto <antti at apple.com>
  Date:   2024-03-22 (Fri, 22 Mar 2024)

  Changed paths:
    A LayoutTests/fast/animation/starting-style-repeat-expected.html
    A LayoutTests/fast/animation/starting-style-repeat.html
    M Source/WebCore/style/StyleTreeResolver.cpp

  Log Message:
  -----------
  [@starting-style] Contents of popover is not rendered when opened a 2nd time
https://bugs.webkit.org/show_bug.cgi?id=271307
rdar://125085007

Reviewed by Antoine Quint.

Repeatedly applying @starting-style may fail because we compute the style diff
against wrong style and may conclude that there is no change and fail to
update the subtree. First time round the renderer is marked invalid so we avoid
this problem.

* LayoutTests/fast/animation/starting-style-repeat-expected.html: Added.
* LayoutTests/fast/animation/starting-style-repeat.html: Added.
* Source/WebCore/style/StyleTreeResolver.cpp:
(WebCore::Style::TreeResolver::createAnimatedElementUpdate):

Take care to diff with the current style.

Canonical link: https://commits.webkit.org/276546@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications