[webkit-changes] [WebKit/WebKit] 8725aa: AX: Move Mac test-only APIs out of [WebAccessibili...

[AndresGonzalezApple]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 8725aa98a9913c1fa4d93c35fa3fa59dce1d0b22
      https://github.com/WebKit/WebKit/commit/8725aa98a9913c1fa4d93c35fa3fa59dce1d0b22
  Author: Andres Gonzalez <andresg_22 at apple.com>
  Date:   2024-03-21 (Thu, 21 Mar 2024)

  Changed paths:
    M Source/WebCore/accessibility/AXObjectCache.cpp
    M Source/WebCore/accessibility/AXObjectCache.h
    M Source/WebCore/accessibility/mac/AXObjectCacheMac.mm
    M Source/WebCore/accessibility/mac/WebAccessibilityObjectWrapperMac.mm
    M Tools/DumpRenderTree/mac/AccessibilityControllerMac.mm
    M Tools/WebKitTestRunner/InjectedBundle/AccessibilityController.cpp
    M Tools/WebKitTestRunner/InjectedBundle/AccessibilityController.h
    M Tools/WebKitTestRunner/InjectedBundle/mac/AccessibilityControllerMac.mm

  Log Message:
  -----------
  AX: Move Mac test-only APIs out of [WebAccessibilityObjectWrapper accessibilityAttributeValue:].
https://bugs.webkit.org/show_bug.cgi?id=271199
<rdar://problem/124976011>

Reviewed by Chris Fleizach.

This makes it clearer that this APIs are for unit test purpose and has a marginal performance benefit since accessibilityAttributeValue has an earlier return for unsupported attributes. This patch also decouples the determination of the client from the isolated tree mode, which are related but the first one should not be dependent on the latter one.

* Source/WebCore/accessibility/AXObjectCache.cpp:
(WebCore::AXObjectCache::shouldServeInitialCachedFrame):
(WebCore::AXObjectCache::getOrCreateIsolatedTree):
* Source/WebCore/accessibility/AXObjectCache.h:
* Source/WebCore/accessibility/mac/AXObjectCacheMac.mm:
(WebCore::AXObjectCache::clientIsInTestMode):
(WebCore::AXObjectCache::isTestClient): Renamed clientIsInTestMode.
* Source/WebCore/accessibility/mac/WebAccessibilityObjectWrapperMac.mm:
(-[WebAccessibilityObjectWrapper accessibilityAttributeValue:]):
(attributeValueForTesting):
* Tools/DumpRenderTree/mac/AccessibilityControllerMac.mm:
(AccessibilityController::AccessibilityController):
* Tools/WebKitTestRunner/InjectedBundle/AccessibilityController.cpp:
(WTR::AccessibilityController::AccessibilityController):
(WTR::AccessibilityController::platformInitialize):
* Tools/WebKitTestRunner/InjectedBundle/AccessibilityController.h:
* Tools/WebKitTestRunner/InjectedBundle/mac/AccessibilityControllerMac.mm:
(WTR::AccessibilityController::platformInitialize):
(WTR::AccessibilityController::updateIsolatedTreeMode):

Canonical link: https://commits.webkit.org/276515@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications