[webkit-changes] [WebKit/WebKit] ba39cb: Expand the list of valid cursor types for Interact...

[Etienne Segonzac]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: ba39cbd5f1cf28d107379ec19cd52267916918ec
      https://github.com/WebKit/WebKit/commit/ba39cbd5f1cf28d107379ec19cd52267916918ec
  Author: Etienne Segonzac <sgz at apple.com>
  Date:   2024-03-21 (Thu, 21 Mar 2024)

  Changed paths:
    A LayoutTests/interaction-region/cursors-expected.txt
    A LayoutTests/interaction-region/cursors.html
    M Source/WebCore/page/InteractionRegion.cpp

  Log Message:
  -----------
  Expand the list of valid cursor types for Interaction Regions
https://bugs.webkit.org/show_bug.cgi?id=271416
<rdar://118882598>

Reviewed by Tim Horton.

Add support for a few more cursor types instead of just `pointer`.
Starting with `move`, `grab`, `text` and `vertical-text`.

* Source/WebCore/page/InteractionRegion.cpp:
(WebCore::hasInteractiveCursorType):
(WebCore::cursorTypeForElement): Deleted.
Rename the function and make it return a bool instead.
(WebCore::interactionRegionForRenderedRegion):
Use the new function.
(WebCore::shouldAllowNonInteractiveCursorForElement):
(WebCore::shouldAllowNonPointerCursorForElement): Deleted.
Rename the function to remove the "pointer" reference.

* LayoutTests/interaction-region/cursors-expected.txt: Added.
* LayoutTests/interaction-region/cursors.html: Added.
Add tests for for the cursors.

Canonical link: https://commits.webkit.org/276511@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications