[webkit-changes] [WebKit/WebKit] 62e3e1: build.webkit.org bots should upload archives direc...

[Brianna Fan]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 62e3e1d1b472669a287ee124839475ad4fe07cbd
      https://github.com/WebKit/WebKit/commit/62e3e1d1b472669a287ee124839475ad4fe07cbd
  Author: Brianna Fan <bfan2 at apple.com>
  Date:   2024-03-21 (Thu, 21 Mar 2024)

  Changed paths:
    M Tools/CISupport/Shared/generate-s3-url
    M Tools/CISupport/build-webkit-org/factories.py
    M Tools/CISupport/build-webkit-org/factories_unittest.py
    M Tools/CISupport/build-webkit-org/steps.py

  Log Message:
  -----------
  build.webkit.org bots should upload archives directly to S3
https://bugs.webkit.org/show_bug.cgi?id=270655
rdar://124300568

Reviewed by Aakash Jain and Jonathan Bedard.

Use GenerateS3URL and UploadFileToS3 in CompileWebKit to upload archives to S3.

* Tools/CISupport/Shared/generate-s3-url:
(main): Adds --minified argument and corresponding bucket.

* Tools/CISupport/build-webkit-org/steps.py:
(ConfigureBuild.__init__):
(ConfigureBuild.start): Adds triggers as a build property so it can be accessed in CompileWebKit.
(DownloadBuiltProduct.run): Allows downloading from master on test instances.
(CompileWebKit.evaluateCommand):
(GenerateS3URL.__init__):
(GenerateS3URL.run):

* Tools/CISupport/build-webkit-org/factories.py:
(Factory.__init__): Adds triggers argument.
(BuildFactory.__init__): Removes archive, upload, and transfer steps. These are added in CompileWebKit.
Also adds triggers argument so that it can be set as a property.

* Tools/CISupport/build-webkit-org/factories_unittest.py:
(TestExpectedBuildSteps):

Canonical link: https://commits.webkit.org/276500@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications