[webkit-changes] [WebKit/WebKit] 65bb28: Remove various CSS-related preferences

[Anne van Kesteren]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 65bb28d2aa9e94ed00efaf9f20be55417c892367
      https://github.com/WebKit/WebKit/commit/65bb28d2aa9e94ed00efaf9f20be55417c892367
  Author: Anne van Kesteren <annevk at annevk.nl>
  Date:   2024-03-21 (Thu, 21 Mar 2024)

  Changed paths:
    M LayoutTests/fast/css/variables/env/invalid-env-name-fallback.html
    M LayoutTests/fast/css/variables/env/ios/safe-area-inset-env-set.html
    M LayoutTests/fast/css/variables/env/safe-area-inset-env-cannot-override.html
    M LayoutTests/fast/css/variables/env/safe-area-inset-env-zero.html
    M LayoutTests/fast/events/ios/rotation/safe-area-insets-during-safari-type-rotation.html
    M LayoutTests/fast/gradients/alpha-premultiplied-representable-by-unpremultiplied-expected.html
    R LayoutTests/fast/gradients/conic-gradient-alpha-unpremultiplied-expected.html
    R LayoutTests/fast/gradients/conic-gradient-alpha-unpremultiplied.html
    M LayoutTests/platform/glib/TestExpectations
    M LayoutTests/platform/wincairo/TestExpectations
    M Source/WTF/Scripts/Preferences/UnifiedWebPreferences.yaml
    M Source/WebCore/css/CSSPseudoSelectors.json
    M Source/WebCore/css/SelectorCheckerTestFunctions.h
    M Source/WebCore/css/parser/CSSParserContext.cpp
    M Source/WebCore/css/parser/CSSParserContext.h
    M Source/WebCore/css/parser/CSSPropertyParserHelpers.cpp
    M Source/WebCore/css/parser/CSSSelectorParserContext.cpp
    M Source/WebCore/css/parser/CSSSelectorParserContext.h
    M Source/WebCore/css/parser/CSSVariableParser.cpp
    M Source/WebCore/dom/Element.cpp
    M Source/WebKitLegacy/mac/WebView/WebPreferenceKeysPrivate.h
    M Source/WebKitLegacy/mac/WebView/WebPreferences.mm
    M Source/WebKitLegacy/mac/WebView/WebPreferencesPrivate.h

  Log Message:
  -----------
  Remove various CSS-related preferences
https://bugs.webkit.org/show_bug.cgi?id=271304

Reviewed by Antti Koivisto.

This removes CSSGradientInterpolationColorSpacesEnabled,
CSSGradientPremultipliedAlphaInterpolationEnabled,
CSSRelativeColorSyntaxEnabled, & FocusVisibleEnabled which have been
stable for over a year.

It also removes ConstantPropertiesEnabled which has essentially been
stable since 2017 or so, but marked embedder possibly because it has
such a confusing name.

Note that CSSGradientColorInterpolationMethod::legacyMethod() could not
be further simplified due to a caller in HTMLInputElement that wants
AlphaPremultiplication::Unpremultiplied.

* LayoutTests/fast/css/variables/env/invalid-env-name-fallback.html:
* LayoutTests/fast/css/variables/env/ios/safe-area-inset-env-set.html:
* LayoutTests/fast/css/variables/env/safe-area-inset-env-cannot-override.html:
* LayoutTests/fast/css/variables/env/safe-area-inset-env-zero.html:
* LayoutTests/fast/events/ios/rotation/safe-area-insets-during-safari-type-rotation.html:
* LayoutTests/fast/gradients/alpha-premultiplied-representable-by-unpremultiplied-expected.html:
* LayoutTests/fast/gradients/conic-gradient-alpha-unpremultiplied-expected.html: Removed.
* LayoutTests/fast/gradients/conic-gradient-alpha-unpremultiplied.html: Removed.
* LayoutTests/platform/glib/TestExpectations:
* LayoutTests/platform/wincairo/TestExpectations:
* Source/WTF/Scripts/Preferences/UnifiedWebPreferences.yaml:
* Source/WebCore/css/CSSPseudoSelectors.json:
* Source/WebCore/css/SelectorCheckerTestFunctions.h:
(WebCore::matchesFocusVisiblePseudoClass):
* Source/WebCore/css/parser/CSSParserContext.cpp:
(WebCore::CSSParserContext::CSSParserContext):
(WebCore::add):
* Source/WebCore/css/parser/CSSParserContext.h:
* Source/WebCore/css/parser/CSSPropertyParserHelpers.cpp:
(WebCore::CSSPropertyParserHelpers::parseRGBParametersRaw):
(WebCore::CSSPropertyParserHelpers::parseHSLParametersRaw):
(WebCore::CSSPropertyParserHelpers::parseHWBParametersRaw):
(WebCore::CSSPropertyParserHelpers::parseLabParametersRaw):
(WebCore::CSSPropertyParserHelpers::parseLCHParametersRaw):
(WebCore::CSSPropertyParserHelpers::parseColorFunctionParametersRaw):
(WebCore::CSSPropertyParserHelpers::consumeDeprecatedLinearGradient):
(WebCore::CSSPropertyParserHelpers::consumeDeprecatedRadialGradient):
(WebCore::CSSPropertyParserHelpers::consumePrefixedRadialGradient):
(WebCore::CSSPropertyParserHelpers::computeGradientColorInterpolationMethod):
(WebCore::CSSPropertyParserHelpers::consumeRadialGradient):
(WebCore::CSSPropertyParserHelpers::consumePrefixedLinearGradient):
(WebCore::CSSPropertyParserHelpers::consumeLinearGradient):
(WebCore::CSSPropertyParserHelpers::consumeConicGradient):
(WebCore::CSSPropertyParserHelpers::gradientAlphaPremultiplication): Deleted.
* Source/WebCore/css/parser/CSSSelectorParserContext.cpp:
(WebCore::CSSSelectorParserContext::CSSSelectorParserContext):
(WebCore::add):
* Source/WebCore/css/parser/CSSSelectorParserContext.h:
* Source/WebCore/css/parser/CSSVariableParser.cpp:
(WebCore::classifyBlock):
* Source/WebCore/dom/Element.cpp:
(WebCore::Element::setHasFocusVisible):
* Source/WebKitLegacy/mac/WebView/WebPreferenceKeysPrivate.h:
* Source/WebKitLegacy/mac/WebView/WebPreferences.mm:
(-[WebPreferences constantPropertiesEnabled]):
(-[WebPreferences setConstantPropertiesEnabled:]):
* Source/WebKitLegacy/mac/WebView/WebPreferencesPrivate.h:

Canonical link: https://commits.webkit.org/276457@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications