[webkit-changes] [WebKit/WebKit] ec673c: [WGSL] shader, validation, shader_io, builtins:* is f...

[Tadeu Zagallo]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: ec673c847c6ae4891c2fc9d259bb377cd1d02cbc
      https://github.com/WebKit/WebKit/commit/ec673c847c6ae4891c2fc9d259bb377cd1d02cbc
  Author: Tadeu Zagallo <tzagallo at apple.com>
  Date:   2024-03-21 (Thu, 21 Mar 2024)

  Changed paths:
    M LayoutTests/http/tests/webgpu/webgpu/shader/validation/shader_io/builtins-expected.txt
    M Source/WebGPU/WGSL/AttributeValidator.cpp
    M Source/WebGPU/WGSL/AttributeValidator.h
    M Source/WebGPU/WGSL/TypeCheck.cpp
    M Source/WebGPU/WGSL/WGSL.cpp
    M Source/WebGPU/WGSL/WGSLEnums.cpp
    M Source/WebGPU/WGSL/WGSLEnums.h

  Log Message:
  -----------
  [WGSL] shader,validation,shader_io,builtins:* is failing
https://bugs.webkit.org/show_bug.cgi?id=271254
rdar://125022496

Reviewed by Mike Wyrzykowski.

Validate builtin attributes according to the spec[1].

[1]: https://www.w3.org/TR/WGSL/#builtin-inputs-outputs

* LayoutTests/http/tests/webgpu/webgpu/shader/validation/shader_io/builtins-expected.txt:
* Source/WebGPU/WGSL/AttributeValidator.cpp:
(WGSL::AttributeValidator::validateIO):
(WGSL::AttributeValidator::validateBuiltinIO):
(WGSL::AttributeValidator::validateLocationIO):
(WGSL::AttributeValidator::validateStructIO):
(WGSL::validateIO):
* Source/WebGPU/WGSL/AttributeValidator.h:
* Source/WebGPU/WGSL/TypeCheck.cpp:
(WGSL::TypeChecker::visit):
* Source/WebGPU/WGSL/WGSL.cpp:
(WGSL::staticCheck):
* Source/WebGPU/WGSL/WGSLEnums.cpp:
* Source/WebGPU/WGSL/WGSLEnums.h:

Canonical link: https://commits.webkit.org/276454@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications