[webkit-changes] [WebKit/WebKit] 66c774: [GStreamer][Quirks] Address review feedback from d...

[Philippe Normand]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 66c774926f3f73835dd2c6cb801a5aafa8c00570
      https://github.com/WebKit/WebKit/commit/66c774926f3f73835dd2c6cb801a5aafa8c00570
  Author: Philippe Normand <philn at igalia.com>
  Date:   2024-03-21 (Thu, 21 Mar 2024)

  Changed paths:
    M Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp
    M Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.h
    M Source/WebCore/platform/gstreamer/GStreamerHolePunchQuirkWesteros.cpp
    M Source/WebCore/platform/gstreamer/GStreamerQuirkAmLogic.cpp
    M Source/WebCore/platform/gstreamer/GStreamerQuirkBroadcom.h
    M Source/WebCore/platform/gstreamer/GStreamerQuirks.cpp
    M Source/WebCore/platform/gstreamer/GStreamerQuirks.h
    M Source/cmake/GStreamerDefinitions.cmake

  Log Message:
  -----------
  [GStreamer][Quirks] Address review feedback from downstream users
https://bugs.webkit.org/show_bug.cgi?id=271308

Reviewed by Xabier Rodriguez-Calvar.

The USE_GSTREAMER_TEXT_SINK and USE_GSTREAMER_NATIVE_{AUDIO,VIDEO} ifdefs were replaced with runtime
quirks. This patch also includes changes requested in
https://github.com/WebPlatformForEmbedded/WPEWebKit/pull/1297.

* Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
(WebCore::MediaPlayerPrivateGStreamer::setPlaybackFlags):
(WebCore::MediaPlayerPrivateGStreamer::createVideoSink):
* Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.h:
(WebCore::MediaPlayerPrivateGStreamer::pipeline const):
* Source/WebCore/platform/gstreamer/GStreamerHolePunchQuirkWesteros.cpp:
(WebCore::GStreamerHolePunchQuirkWesteros::createHolePunchVideoSink):
* Source/WebCore/platform/gstreamer/GStreamerQuirkAmLogic.cpp:
(WebCore::GStreamerQuirkAmLogic::configureElement):
* Source/WebCore/platform/gstreamer/GStreamerQuirkBroadcom.h:
* Source/WebCore/platform/gstreamer/GStreamerQuirks.cpp:
(WebCore::GStreamerQuirksManager::getAdditionalPlaybinFlags const):
* Source/WebCore/platform/gstreamer/GStreamerQuirks.h:
(WebCore::GStreamerQuirk::getAdditionalPlaybinFlags const):
* Source/cmake/GStreamerDefinitions.cmake:

Canonical link: https://commits.webkit.org/276450@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications