[webkit-changes] [WebKit/WebKit] db57a9: [iOS] Entering fullscreen from iframe without expl...

[Jer Noble]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: db57a9aa346bded84559a78247d35ad528795990
      https://github.com/WebKit/WebKit/commit/db57a9aa346bded84559a78247d35ad528795990
  Author: Jer Noble <jer.noble at apple.com>
  Date:   2024-03-20 (Wed, 20 Mar 2024)

  Changed paths:
    M Source/WebKit/WebProcess/FullScreen/WebFullScreenManager.cpp

  Log Message:
  -----------
  [iOS] Entering fullscreen from iframe without explicit viewport results in badly cropped video
https://bugs.webkit.org/show_bug.cgi?id=270909
rdar://123725878

Reviewed by Eric Carlson.

Follow-up fix to 276138 at main: resetViewportDefaultConfiguration() will not trigger viewportDidChange(),
and therefore calling those methods in that order can leave the calculated viewport in an inconsistent state.
Instead, ensure resetViewportDefaultConfiguration() is called before viewportDidChange() by calling
isInFullscreenChanged() before willEnterFullscreen().

* Source/WebKit/WebProcess/FullScreen/WebFullScreenManager.cpp:
(WebKit::WebFullScreenManager::willEnterFullScreen):

Canonical link: https://commits.webkit.org/276427@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications