[webkit-changes] [WebKit/WebKit] d98b64: `--site-isolation` should not run every test as a ...

Charlie Wolfe noreply at github.com
Wed Mar 20 13:41:44 PDT 2024


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: d98b641aed396224fa6fdbeb2dbadac07ebfa803
      https://github.com/WebKit/WebKit/commit/d98b641aed396224fa6fdbeb2dbadac07ebfa803
  Author: Charlie Wolfe <charliew at apple.com>
  Date:   2024-03-20 (Wed, 20 Mar 2024)

  Changed paths:
    M LayoutTests/platform/mac-site-isolation/TestExpectations
    M Tools/Scripts/webkitpy/layout_tests/controllers/single_test_runner.py
    M Tools/Scripts/webkitpy/layout_tests/run_webkit_tests.py

  Log Message:
  -----------
  `--site-isolation` should not run every test as a reference test
https://bugs.webkit.org/show_bug.cgi?id=271298
rdar://125064104

Reviewed by Pascoe and Alex Christensen.

`-—site-isolation` uses `--self-compare-with-header` to compare the output of a test in a cross-origin
iframe with and without site isolation enabled. However, `-—self-compare-with-header` will force each
test to run as a reference test. For testing site isolation, tests that intend to output and compare
text should still do so.

* LayoutTests/platform/mac-site-isolation/TestExpectations:
* Tools/Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
(SingleTestRunner):
(SingleTestRunner._run_self_comparison_without_reference_test):
* Tools/Scripts/webkitpy/layout_tests/run_webkit_tests.py:
(_set_up_derived_options):

Canonical link: https://commits.webkit.org/276416@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications


More information about the webkit-changes mailing list